Changing visibility of ekore and Splitting constants.rs#543
Conversation
|
I was a bit confused in placing of Second, there was a warning in This is not a pre-commit issue, just a warning that these three things, |
felixhekhorn
left a comment
There was a problem hiding this comment.
- Please add a Changelog entry
- I'm not sure yet what to do with the unused functions ... let's discuss tomorrow; most likely we will just drop them
63c3375 to
a9fc8b9
Compare
a9fc8b9 to
f157469
Compare
|
So |
|
I change my mind again: let's keep the functions! sorry 😇 can you please just revert 0bece9e ? We need them when we port to Rust.Here comes a math statement: at a given order in the coupling (e.g. |
0bece9e to
f157469
Compare
|
All 4 functions are back now |
This PR fixes #539, and is a pre-requisite to #537.
ekorecrate.pubwas converted topub(super), and if that resulted in error it was converted topub(crate).constants.rsto 3 files:math_constants.rswith all the Zeta function values.qcd_constants.rswith all QCD constants.pid.rswith the rest of the constants, withPID_*andMAX_ORDER_*being the only public constants (are/will be exposed publicly in the future).