fix(mcp): pin mcp<2.0.0 and report fastmcp removal accurately - #355
Open
erensh27 wants to merge 1 commit into
Open
fix(mcp): pin mcp<2.0.0 and report fastmcp removal accurately#355erensh27 wants to merge 1 commit into
erensh27 wants to merge 1 commit into
Conversation
mcp 2.0.0 (2026-07-28) removed mcp.server.fastmcp, so a fresh 'skillspector[mcp]' install could resolve mcp 2.x and then fail at server start with the misleading 'requires the optional mcp dependency' error even though mcp is installed. - pyproject.toml: cap the extra at mcp<2.0.0. - mcp_server.py: on import failure, check whether mcp itself is importable; if it is, report that mcp.server.fastmcp was removed (mcp>=2.0.0) instead of claiming the extra is missing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #333.
Two fixes:
mcpextra atmcp<2.0.0: mcp 2.0.0 (released 2026-07-28) removedmcp.server.fastmcp, so freshskillspector[mcp]installs could resolve mcp 2.x and then fail at server init.mcpitself is importable. If it is, the problem is the missingmcp.server.fastmcpsubmodule (mcp>=2.0.0), so the error now says so and points atpip install 'skillspector[mcp]'for a compatible pin, instead of the misleading "optional 'mcp' dependency is missing" message.Reproduction from the issue now yields a truthful error under mcp 2.x, and
pip install 'skillspector[mcp]'no longer resolves to mcp 2.x at all.