[CuteDSL] Fix source location info for cute.arch.elect_one#3317
Open
pchen7e2 wants to merge 1 commit into
Open
[CuteDSL] Fix source location info for cute.arch.elect_one#3317pchen7e2 wants to merge 1 commit into
pchen7e2 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
locinfo was missed when creatingnvvm.elect_sync. This means the later pipelines would not be able to tell that NVVM Op was from "this line of kernel source". The fix is to attach it.We can check the effect by looking at source mapping in ncu:
Before: (elect.sync was not mapped correctly. In fact it's mapped to a line
@cute.jit)After: (elect.sync was correctly mapped)