Skip to content

nixos/cosmic: remove unnecessary dependency of cosmic-session.target on xdg-desktop-autostart.target#519447

Merged
GaetanLepage merged 1 commit into
NixOS:masterfrom
thefossguy:cosmic-module-remove-redundant-autostart-target-deps
Jun 24, 2026
Merged

nixos/cosmic: remove unnecessary dependency of cosmic-session.target on xdg-desktop-autostart.target#519447
GaetanLepage merged 1 commit into
NixOS:masterfrom
thefossguy:cosmic-module-remove-redundant-autostart-target-deps

Conversation

@thefossguy

@thefossguy thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member

…

Things done

  • Built on platform:
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Tested, as applicable:
  • Ran nixpkgs-review on this PR. See nixpkgs-review usage.
  • Tested basic functionality of all binary files, usually in ./result/bin/.
  • Nixpkgs Release Notes
    • Package update: when the change is major or breaking.
  • NixOS Release Notes
    • Module addition: when adding a new NixOS module.
    • Module update: when the change is significant.
  • Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs.

@thefossguy thefossguy requested a review from a team May 12, 2026 14:33
@thefossguy

thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member Author

XDG autostart still works after this removal. Tested it by rebasing #519448 on top of this PR's HEAD and it works just fine.

@nixpkgs-ci nixpkgs-ci Bot added 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences labels May 12, 2026
a-kenji
a-kenji approved these changes May 12, 2026
View reviewed changes

@a-kenji a-kenji left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, didn't test yet.

@nixpkgs-ci nixpkgs-ci Bot added the 12.approvals: 2 This PR was reviewed and approved by two persons. label May 12, 2026
@thefossguy

thefossguy commented May 12, 2026

Copy link
Copy Markdown
Member Author

Let's hold off on merging this for a day or two until we have either the cosmic-osd fix in as a backport or as a release. Then merge the nixosTest refactor and then this one.

@thefossguy thefossguy marked this pull request as draft May 13, 2026 02:02
@nyabinary

nyabinary commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Let's hold off on merging this for a day or two until we have either the cosmic-osd fix in as a backport or as a release. Then merge the nixosTest refactor and then this one.

Test refactor merged now :3

@thefossguy thefossguy marked this pull request as ready for review June 23, 2026 22:25
Pandapip1
Pandapip1 approved these changes Jun 24, 2026
View reviewed changes

@Pandapip1 Pandapip1 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM; also haven't tested

@thefossguy

thefossguy commented Jun 24, 2026 via email

Copy link
Copy Markdown
Member Author

@thefossguy

thefossguy commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 519447 --extra-nixpkgs-config '{ allowBroken = true; allowUnfree = true; }' --additional-package nixosTests.cosmic-autologin-noxwayland --additional-package nixosTests.cosmic-autologin --additional-package nixosTests.cosmic-noxwayland --additional-package nixosTests.cosmic
Commit: 518687b52b2c77e4b34034362ff6f0107a400347

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 tests built:
  • nixosTests.cosmic
  • nixosTests.cosmic-autologin
  • nixosTests.cosmic-autologin-noxwayland
  • nixosTests.cosmic-noxwayland

@thefossguy

thefossguy commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 519447 --extra-nixpkgs-config '{ allowBroken = true; allowUnfree = true; }' --additional-package nixosTests.cosmic-noxwayland --additional-package nixosTests.cosmic-autologin --additional-package nixosTests.cosmic-autologin-noxwayland --additional-package nixosTests.cosmic
Commit: 518687b52b2c77e4b34034362ff6f0107a400347

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 tests built:
  • nixosTests.cosmic
  • nixosTests.cosmic-autologin
  • nixosTests.cosmic-autologin-noxwayland
  • nixosTests.cosmic-noxwayland

@thefossguy

thefossguy commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

In the recently refactored NixOS VM tests, the test is in a script that is executed upon login because of XDG autostart. As long as the test script start, we're good with XDG autostart. With the test not only starting but finishing successfully, this indicates that the delta I proposed is no longer necessary. :)

@thefossguy thefossguy requested a review from GaetanLepage June 24, 2026 04:46
@nixpkgs-ci nixpkgs-ci Bot added 12.approvals: 3+ This PR was reviewed and approved by three or more persons. and removed 12.approvals: 2 This PR was reviewed and approved by two persons. labels Jun 24, 2026
@GaetanLepage

GaetanLepage commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 519447
Commit: 518687b52b2c77e4b34034362ff6f0107a400347

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test

@GaetanLepage GaetanLepage added this pull request to the merge queue Jun 24, 2026
Merged via the queue into NixOS:master with commit 8986b01 Jun 24, 2026
40 of 42 checks passed
@thefossguy thefossguy deleted the cosmic-module-remove-redundant-autostart-target-deps branch June 24, 2026 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@GaetanLepage GaetanLepage GaetanLepage approved these changes
+3 more reviewers
@Pandapip1 Pandapip1 Pandapip1 approved these changes
@a-kenji a-kenji a-kenji approved these changes
@nyabinary nyabinary nyabinary approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

6.topic: COSMIC COSMIC is a software platform for designing beautiful user experiences 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin. 10.rebuild-linux: 1-10 This PR causes between 1 and 10 packages to rebuild on Linux. 12.approvals: 3+ This PR was reviewed and approved by three or more persons.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@thefossguy @nyabinary @GaetanLepage @Pandapip1 @a-kenji