Skip to content

Cosmic test improvement polkit changes#530915

Closed
thefossguy wants to merge 21 commits into
NixOS:masterfrom
thefossguy:cosmic-test-improvement-polkit-changes
Closed

Cosmic test improvement polkit changes#530915
thefossguy wants to merge 21 commits into
NixOS:masterfrom
thefossguy:cosmic-test-improvement-polkit-changes

Conversation

@thefossguy

@thefossguy thefossguy commented Jun 12, 2026

Copy link
Copy Markdown
Member

Things done

thefossguy and others added 21 commits June 11, 2026 12:45
@thefossguy
nixosTests/cosmic: move test into a dedicated directory
fae2ab3
@thefossguy
empty-pdf: init
4ae53d2
@thefossguy
nixosTests/cosmic: move core testing logic into a dedicated script
0ef6027
@thefossguy
nixosTests/cosmic: add test for polkit authentication
5b01aec
@mweinelt @thefossguy
nixos/polkit: modernize
6c79e55
@mweinelt @thefossguy
nixos/polkit: make pkexec opt-in
a489b41
@mweinelt @thefossguy
nixos/installers/calamares: opt into pkexec
55b200a
@mweinelt @thefossguy
nixos/throne: opt into pkexec
6e5409b 
https://github.com/throneproj/Throne/blob/4.3.7/src/ui/mainwindow.cpp#L843-L847
@mweinelt @thefossguy
nixos/xfce: opt into pkexec
fc6ff04 
https://github.com/search?q=org%3Axfce-mirror%20pkexec&type=code
@mweinelt @thefossguy
nixos/cinnamon: opt into pkexec
66f492b 
https://github.com/search?q=repo%3Alinuxmint%2Fcinnamon%20pkexec&type=code
@mweinelt @thefossguy
nixos/cosmic: opt into pkexec
4d8c7d1 
https://github.com/search?q=org%3Apop-os%20pkexec&type=code
@mweinelt @thefossguy
nixos/budgie: opt into pkexec
7280599 
https://github.com/search?q=org%3ABuddiesOfBudgie%20pkexec&type=code
@mweinelt @thefossguy
nixos/gnome: opt into pkexec
54265a3
@mweinelt @thefossguy
nixos/tuned: opt into pkexec
fcef121
@mweinelt @thefossguy
nixos/tests/timekpr: hook up in all-tests, migrate to container
aa7f76a
@mweinelt @thefossguy
nixos/security/run0: enable guard, polkit, refactor
e6d0969 
The module now enables polkit, which run0 requires to faciliate
elevation. This warrants guarding the config by an opt-in enable toggle.

For the options that existed prior to the enable toggle we now assert
that users need to opt into the module for them to have an effect.
@mweinelt @thefossguy
nixos/gnome-remote-desktop: opt into pkexec
3071865 
Calls pkexec in src/grd-ctl.c.
@mweinelt @thefossguy
nixos/installer/tools: enable run0 module
8220e80 
The run0 module now enables polkit and properly reflects the intent
behind the `enableRun0Elevation` option.
@mweinelt @r-vdp
@LordGrimmauld @thefossguy
nixos/polkit: stop if changed
9ba09b4 
We concluded this is fine, because we don't require elevation while
switching generations.

Co-Authored-By: r-vdp <ramses@well-founded.dev>
Co-Authored-By: Grimmauld <Grimmauld@grimmauld.de>
@mweinelt @thefossguy
nixos/test/lomiri/desktop-appinteractions: use run0 for elevation
9a15257
@mweinelt @thefossguy
nixos/gamemode: opt into pkexec
cbab082
@thefossguy thefossguy closed this Jun 12, 2026
@thefossguy

thefossguy commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

PR containing proposed changes in #530106 on top of #519448.

@thefossguy

thefossguy commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 530915 --extra-nixpkgs-config '{ allowBroken = true; allowUnfree = true; }' --additional-package nixosTests.cosmic-noxwayland --additional-package nixosTests.cosmic --additional-package nixosTests.cosmic-autologin-noxwayland --additional-package nixosTests.cosmic-autologin
Commit: cbab082653300399f262ee618acf14e3248cce6a

aarch64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 tests built:
  • nixosTests.cosmic
  • nixosTests.cosmic-autologin
  • nixosTests.cosmic-autologin-noxwayland
  • nixosTests.cosmic-noxwayland
✅ 1 package built:
  • empty-pdf

@thefossguy

thefossguy commented Jun 12, 2026

Copy link
Copy Markdown
Member Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 530915 --extra-nixpkgs-config '{ allowBroken = true; allowUnfree = true; }' --additional-package nixosTests.cosmic-autologin --additional-package nixosTests.cosmic-autologin-noxwayland --additional-package nixosTests.cosmic-noxwayland --additional-package nixosTests.cosmic
Commit: cbab082653300399f262ee618acf14e3248cce6a

x86_64-linux

⏩ 2 packages blacklisted:
  • nixos-install-tools
  • tests.nixos-functions.nixos-test
✅ 4 tests built:
  • nixosTests.cosmic
  • nixosTests.cosmic-autologin
  • nixosTests.cosmic-autologin-noxwayland
  • nixosTests.cosmic-noxwayland
✅ 1 package built:
  • empty-pdf

@thefossguy thefossguy mentioned this pull request Jun 12, 2026
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@thefossguy @mweinelt