gnuplot: enable bitmap terminals#533595
Closed
mvonbuelow wants to merge 1 commit into
Closed
Conversation
nixpkgs-ci
Bot
added
10.rebuild-linux: 101-500
Author
|
Uzlkav
suggested changes
Jun 26, 2026
Uzlkav
left a comment
Uzlkav
left a comment
Contributor
There was a problem hiding this comment.
Hi, welcome to nixpkgs! Thanks for contributing.
Diff looks good, have one proposed change to make the flag overridable. Looks like minc_widgets is failing to build for other reasons, so making this the default seems fine.
| ''; | ||
|
|
||
| configureFlags = [ | ||
| "--with-bitmap-terminals" |
Contributor
There was a problem hiding this comment.
Consider making this overridable
Suggested change
| "--with-bitmap-terminals" | |
| (if withBitmapTerminals then "--with-bitmap-terminals" else "--whatever-the-disable-option-is") |
And at the top of the file, add withBitmapTerminals ? true to the attr set
Optionally enable gnuplot bitmap terminals by passing --with-bitmap-terminals to configure. This enables legacy bitmap-based terminal drivers (e.g. pbm, epson, hpljii, hp500c) without introducing additional dependencies.
mvonbuelow
force-pushed
the
gnuplot-bitmap-terminals
branch
from
b88986a to
7d33cc0
Compare
11 tasks
Author
Contributor
|
No worries! An interactive rebase might help you in the future, see this site for a quick guide: https://git-rebase.io |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
gnuplot: enable bitmap terminals
Enable gnuplot bitmap terminals by passing
--with-bitmap-terminalsto configure.This enables legacy bitmap-based terminal drivers (e.g. pbm, epson, hpljii, hp500c) without introducing additional dependencies.
Things done
Built on platform:
Tested, as applicable:
./result/bin/:gnuplot -e "set term"shows additional bitmap terminals[Nixpkgs tests] in [nixos/tests].
[Package tests] at
passthru.tests.Ran
nixpkgs-reviewon this PR.NixOS Release Notes / Package update (not applicable)
Fits CONTRIBUTING.md, pkgs/README.md, maintainers/README.md and other READMEs
Follows the automation/AI policy