fix(discord): paginate model picker beyond 25 providers/models#41029
Closed
dragocz1995 wants to merge 1 commit into
Closed
fix(discord): paginate model picker beyond 25 providers/models#41029dragocz1995 wants to merge 1 commit into
dragocz1995 wants to merge 1 commit into
Conversation
Discord select menus are capped at 25 options. ModelPickerView truncated both the provider list (`options[:25]`) and per-provider model list (`models[:25]`), silently hiding everything past the 25th entry — with `list_picker_providers(max_models=50)` up to half the models per provider were unreachable from the dropdown. Split both dropdowns into pages of 25 with ◀ Prev / Next ▶ buttons (shown only when more than one page exists, disabled at the bounds) and a page indicator in the placeholder. Single-page lists are unchanged. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Contributor
|
Fixed on This was one of several PRs targeting the same picker cap. We merged @islam666's #48297 as the implementation (cleanest scope — it correctly keeps the Telegram/Discord inline-keyboard cap, which genuinely needs a bound) plus a follow-up tightening |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Discord select menus are capped at 25 options.
ModelPickerViewtruncated boththe provider dropdown (
options[:25]) and the per-provider model dropdown(
models[:25]), silently hiding everything past the 25th entry. The gatewaybuilds the picker with
list_picker_providers(max_models=50), so up to half themodels per provider were unreachable from the dropdown — and any deployment with
more than 25 providers couldn't reach the rest at all.
Change
Next ▶ buttons.
disabled at the first/last page.
(page X/Y)indicator when paginated.Stays within Discord's view limits (one select row + one button row). The
existing "N more available — type
/model <name>directly" hint now onlyfires for models beyond the
max_modelscap rather than the 25-option UI limit.Testing
Constructed
ModelPickerViewwith 60 providers × 50 models and verified eachpage renders ≤25 options, Prev/Next enable/disable correctly at the bounds, and
single-item lists show no navigation buttons.