Skip to content

fix(constants): ignore host container runtime mounts#48598

Open
BROCCOLO1D wants to merge 2 commits into
NousResearch:mainfrom
BROCCOLO1D:fix/48594-container-mountinfo-host
Open

fix(constants): ignore host container runtime mounts#48598
BROCCOLO1D wants to merge 2 commits into
NousResearch:mainfrom
BROCCOLO1D:fix/48594-container-mountinfo-host

Conversation

@BROCCOLO1D

Copy link
Copy Markdown
Contributor

Summary

Why

Changes

  • hermes_constants.py: keep existing explicit Docker/Podman/Kubernetes/cgroup checks, but only trust the cgroup-v2 mountinfo fallback when the runtime marker appears on the actual / mount.
  • tests/test_hermes_constants.py: add a regression case for a host root mount plus a separate /var/lib/containerd/... mount.

Validation

  • python -m pytest tests/test_hermes_constants.py -o 'addopts=' -q (47 passed)
  • python -m py_compile hermes_constants.py
  • git diff --check

Scope

  • In scope: preventing host container-runtime mounts from tripping is_container() while preserving root-mount cgroup-v2 container detection.
  • Out of scope: changing dashboard update-control logic or unrelated service-manager/container detection paths.

@alt-glitch alt-glitch added type/bug Something isn't working comp/cli CLI entry point, hermes_cli/, setup wizard area/docker Docker image, Compose, packaging P2 Medium — degraded but workaround exists labels Jun 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/docker Docker image, Compose, packaging comp/cli CLI entry point, hermes_cli/, setup wizard P2 Medium — degraded but workaround exists type/bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Dashboard update controls hidden on systemd host with Docker/containerd running

2 participants