fix(desktop): avoid linux hidden titlebar freeze#48606
Open
tt-a1i wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleBarStyle: hidden/titleBarOverlay.-webkit-app-region:dragstrips when Linux uses native titlebars, covering the main shell, secondary chat windows, and route overlays.Fixes #48515.
Validation
cd apps/desktop && node --test electron/window-chrome.test.cjsnpm run typecheck --workspace apps/desktopcd apps/desktop && npx eslint electron/main.cjs electron/window-chrome.cjs electron/window-chrome.test.cjs src/app/shell/app-shell.tsx src/app/shell/titlebar.ts src/store/updates.test.ts src/components/assistant-ui/thread-list.tsx src/app/overlays/overlay-view.tsxcd apps/desktop && npx prettier --check electron/window-chrome.cjs electron/window-chrome.test.cjs src/app/shell/app-shell.tsx src/app/shell/titlebar.ts src/app/overlays/overlay-view.tsx src/components/assistant-ui/thread-list.tsx src/global.d.ts src/store/updates.test.ts package.jsonnpm run test:ui --workspace apps/desktop -- src/app/shell/titlebar.test.ts src/store/updates.test.tsgit diff --checkNotes
npm run test:desktop:platforms --workspace apps/desktopstill fails on an existing unrelated static-scan expectation inelectron/windows-child-process.test.cjs: it looks for the literal substringexecFileSync(pyExe, while currentmain.cjshas that call split over multiple lines onorigin/main.