Added optional parameters to specify the times for the timeframe between from & to dates.#556
Open
SohamBhambare wants to merge 2 commits into
Open
Added optional parameters to specify the times for the timeframe between from & to dates.#556SohamBhambare wants to merge 2 commits into
SohamBhambare wants to merge 2 commits into
Conversation
Added optional fromTime=/toTime= (HH:mm:ss) query params to /api/messages/list, layered on top of the existing from=/to= date filters, so callers can bound results to an exact date+time window instead of only whole calendar days.
test file that verifies the from/to/fromTime/toTime resolution logic in ListMessagesCommand — covering valid combinations, defaulting rules, and all the error cases (missing date for a given time, inverted ranges, malformed input).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extended the /api/messages/list date-range filter (originally added to fix an OOM from unbounded queries) with optional time-of-day precision (fromTime=/toTime=), so callers can bound results to an exact date+time window instead of only whole calendar days — with validation that rejects ambiguous or contradictory inputs rather than silently guessing.