Fix CA/CRL refresh retriggering every run on 304#493
Open
houssemexo26 wants to merge 1 commit into
Open
Conversation
Author
|
@bastelfreak, could you look at my PR please? Thanks |
Contributor
|
LGTM, but a dupe of #440 . |
When the server responds with 304 Not Modified, ca_last_update and crl_last_update were not updated. Since these read the mtime of the CA cert / CRL file on disk, the stale timestamp caused needs_refresh? to return true on every subsequent run, ignoring ca_refresh_interval and crl_refresh_interval. Fix by updating the timestamp on 304 so the interval is respected. Signed-off-by: Houssem eXo <hbenali@exoplatform.fr>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the server responds with 304 Not Modified, ca_last_update and crl_last_update were not updated. Since these read the mtime of the CA cert / CRL file on disk, the stale timestamp caused needs_refresh? to return true on every subsequent run, ignoring ca_refresh_interval and crl_refresh_interval.
Fix by updating the timestamp on 304 so the interval is respected.
Short description
Checklist
I have:
Signed-off-byannotation to each of my commitsGenerated-byorAssisted-byannotations to each of my commits created with the help of an AI agent