fix: wait for publish operation to complete before reporting success#93
Open
DanielSinclair wants to merge 1 commit into
Open
fix: wait for publish operation to complete before reporting success#93DanielSinclair wants to merge 1 commit into
DanielSinclair wants to merge 1 commit into
Conversation
submit() previously fired the publish request and returned immediately after receiving a 202 Accepted, without verifying the publish operation actually succeeded. This meant async failures (e.g. NoModulesUpdated, InProgressSubmission, SubmissionValidationError) were silently ignored and the extension remained as a draft. Add waitForPublish() that polls getPublishStatus() — mirroring the existing waitForUpload() pattern — so publish failures now surface as errors instead of false successes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
submit()previously fired the publish request and returned immediately after receiving a 202 Accepted, without polling the publish status endpoint to verify the operation completed. ThegetPublishStatus()method existed but was never called from the submit flow.This meant async publish failures were silently ignored and the extension remained as a draft. The following error codes would go undetected:
NoModulesUpdated— no changes since last submissionInProgressSubmission— another submission already under reviewSubmissionValidationError— submission validation failuresModuleStateUnPublishable— extension has invalid modulesUnpublishInProgress— extension is being unpublishedCreateNotAllowed— can't create new extensionChanges
submit()now callswaitForPublish()afterpublish(), pollinggetPublishStatus()until the operation reachesSucceededorFailedwaitForUpload()pattern and Microsoft's reference implementation (10 retries, 5s intervals)publishStatus.status === "Succeeded"Test plan
pnpm dlx @plasmohq/mystic-box test-zip 0.0.8+ validkey.json"Publish operation timed out"