Retire legacy Marketplace coverage input#8693
Draft
daphnehanse11 wants to merge 2 commits into
Draft
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #8693 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 47 31 -16
Branches 0 1 +1
=========================================
- Hits 47 31 -16
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #8674
Summary
This PR retires the legacy Marketplace coverage input from the active input/export surface while preserving the variable name as a compatibility alias. It also canonicalizes household health benefit accounting on annual health-value variables, including
assigned_aca_ptcrather than the monthlypremium_tax_creditwrapper.API partner implications
This is intentionally API-surface-relevant:
has_marketplace_health_coverageis no longer an active input variable discovered from PE-US metadata.has_marketplace_health_coverage_at_interview.has_marketplace_health_coverage.has_marketplace_health_coverage_at_interview.takes_up_aca_if_eligible.healthcare_benefit_value/assigned_aca_ptc;premium_tax_creditremains a monthly wrapper.Health accounting semantics
healthcare_benefit_value: annual canonical household resource value of health coverage.household_health_benefits: annual health value included inhousehold_benefitsonly whengov.simulation.include_health_benefits_in_net_incomeis enabled.medicaid,chip, and monthlypremium_tax_creditare no longer listed in household health benefits to avoid double-counting or period mismatch.Tests
uv run policyengine-core test policyengine_us/tests/policy/baseline/household/household_health_benefits.yaml policyengine_us/tests/policy/baseline/household/healthcare_benefit_value.yaml policyengine_us/tests/policy/baseline/household/expense/health/has_marketplace_health_coverage.yaml policyengine_us/tests/policy/baseline/gov/aca/ptc/premium_tax_credit.yaml policyengine_us/tests/policy/baseline/gov/aca/eligibility/is_aca_ptc_eligible.yaml policyengine_us/tests/policy/baseline/gov/aca/ptc/aca_ptc.yaml -c policyengine_usuv run pytest policyengine_us/tests/core/test_input_variable_definitions.py -quv run policyengine-core test policyengine_us/tests/policy/baseline/household/household_health_benefits.yaml -c policyengine_usmake formatgit diff --checkCI follow-up
An initial CI changelog check failed because the fragment used the old
changelog.d/fixed/8674.mdpath. This branch now useschangelog.d/8674.fixed.md, matching the current PR workflow.