Skip to content

RE1-T117 twilio fix #414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucswift merged 1 commit into from
Jun 22, 2026
+15 −2
Merged

RE1-T117 twilio fix #414

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions Web/Resgrid.Web.Services/Controllers/TwilioController.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -297,9 +297,14 @@ private async System.Threading.Tasks.Task ProcessTextCommandsAsync(TextMessage t
// only hit the DB again if the department came from the phone-number lookup path.
var profile = userProfile ?? await _userProfileService.GetProfileByMobileNumberAsync(textMessage.Msisdn);

// Diagnostic: no matching user profile for the sender's number means no reply is added.
// No matching user profile for the sender's number: reply so the user knows, rather than
// returning an empty response (pre-refactor behavior).
if (profile == null)
Framework.Logging.LogInfo($"[Twilio SMS] DepartmentId={departmentId.Value} sender {textMessage.Msisdn} has no matching user profile; no reply will be sent.");
{
Framework.Logging.LogInfo($"[Twilio SMS] DepartmentId={departmentId.Value} sender {textMessage.Msisdn} has no matching user profile; replying with not-found message.");
messageEvent.Processed = true;
response.Message("Resgrid: We couldn't find a Resgrid user linked to this mobile number. Please add this number to your Resgrid profile to use text commands.");
}

if (profile != null)
{
Expand Down Expand Up @@ -517,6 +522,14 @@ private async System.Threading.Tasks.Task ProcessTextCommandsAsync(TextMessage t
}
}
}
else
{
// Department resolved but its plan doesn't include inbound text messaging (only the free
// tier lacks it): reply instead of returning an empty response (pre-refactor behavior).
Framework.Logging.LogInfo($"[Twilio SMS] DepartmentId={departmentId.Value} not authorized for inbound text (plan gate); replying with unsupported message.");
messageEvent.Processed = true;
response.Message("Resgrid: Inbound text messaging isn't available on your department's current plan. Please upgrade to a paid plan to enable text commands.");
}
}
else if (textMessage.To == Config.NumberProviderConfig.TwilioResgridNumber) // Resgrid master text number
{
Expand Down
Loading