fix(communication): reject non-positive service call timeout_sec#819
Open
Bartok9 wants to merge 1 commit into
Open
fix(communication): reject non-positive service call timeout_sec#819Bartok9 wants to merge 1 commit into
Bartok9 wants to merge 1 commit into
Conversation
Add require_positive_timeout helper and gate ROS2ServiceAPI.call_service before building the request or touching clients. Offline unit tests cover bool/non-numeric/non-positive cases.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Gate
ROS2ServiceAPI.call_servicesotimeout_secmust be a finite number > 0. Bool and non-numeric values raiseTypeError; non-positive values raiseValueErrorbefore any request build or client touch.Shared helper:
rai.communication.timeout_validate.require_positive_timeout(ROS-free).Test plan
pytest tests/communication_offline/test_service_timeout_validate.py(7 passed)Notes
Small fail-closed guard; default
timeout_sec=5.0behavior unchanged for valid callers. AI-assisted; human-reviewed.