fix(ci): license header + align zero-timeout test with #808#826
Merged
maciejmajek merged 1 commit intoJul 22, 2026
Merged
Conversation
rejection - tests/communication/__init__.py: add Apache license header (check-license-lines) - test_ros2_async.py: zero timeout now expects ValueError, matching get_future_result rejecting non-positive timeout_sec (RobotecAI#808)
maciejmajek
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #824 as requested by @maciejmajek — the two CI fixes for the salvage batch.
Changes
tests/communication/__init__.py(was empty).test_get_future_result_zero_timeoutwith the intended behavior from fix(ros2): reject non-positive timeout_sec in get_future_result #808 —get_future_resultnow rejects non-positivetimeout_secwithValueError, so the staleassert Nonebecomespytest.raises(ValueError).Based on
bartok9/fixesso the #808 rejection change is present. Happy to retarget tomainor fold in however is easiest. 🎻