fix(s2s): reject non-positive sound device read duration#845
Open
Bartok9 wants to merge 2 commits into
Open
Conversation
rejection - tests/communication/__init__.py: add Apache license header (check-license-lines) - test_ros2_async.py: zero timeout now expects ValueError, matching get_future_result rejecting non-positive timeout_sec (RobotecAI#808)
Signed-off-by: Bartok9 <danielrpike9@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SoundDeviceAPI.read(time)now requires a positive duration before calling into sounddeviceMotivation
time <= 0yields frames=0 and a useless capture; invalid types crash deeper in the stack.Verification
python -m pytest tests/s2s/test_sound_device_read_duration.py -q(importlib offline)Notes
bartok9/fixesAgent-Owner:
sera· Platform: hermes · Claim-TTL: 24h