fix: in firmware/asm/lcd-as-memframe in lcd-as-memframe.c#17
Open
orbisai0security wants to merge 1 commit into
Open
fix: in firmware/asm/lcd-as-memframe in lcd-as-memframe.c#17orbisai0security wants to merge 1 commit into
orbisai0security wants to merge 1 commit into
Conversation
Automated security fix generated by Orbis Security AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix critical severity security issue in
firmware/asm/lcd-as-memframe.c.Vulnerability
V-001firmware/asm/lcd-as-memframe.c:7Description: In firmware/asm/lcd-as-memframe.c:7, memcpy is called with a size derived from 'width * sizeof(fb_data)'. If 'width' originates from an externally-supplied media file or display data without bounds validation, an attacker can supply a crafted value causing the copy to exceed the destination buffer, overwriting adjacent memory including return addresses or function pointers. Similarly, firmware/asm/m68k/pcm-mixer.c:113 calls memcpy with a 'size' parameter that may be externally influenced. No bounds checking is evident at these call sites.
Changes
firmware/asm/lcd-as-memframe.cVerification
Automated security fix by OrbisAI Security