Skip to content

feat: replace hardcoded jobs with configurable actions #2351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
minottic wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat: replace hardcoded jobs with configurable actions #2351

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9e1e0cd
feat: replace hardcoded jobs with configurable actions
minottic Apr 22, 2026
e5a9725
Add actions effect to open snackbar
minottic Apr 23, 2026
378e36c
Add tests
minottic Apr 23, 2026
cb5f7a6
Narrow types
minottic Apr 23, 2026
dd9f3e7
Extend top level configurable actions doc
minottic Jun 17, 2026
3af44e1
Address copilot suggestions
minottic Jun 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
202 changes: 0 additions & 202 deletions src/app/datasets/archiving.service.spec.ts
View file
Open in desktop

This file was deleted.

134 changes: 0 additions & 134 deletions src/app/datasets/archiving.service.ts
View file
Open in desktop

This file was deleted.

20 changes: 5 additions & 15 deletions src/app/datasets/batch-view/batch-view.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,21 +84,11 @@
Share
</button>
</ng-container>
<ng-container *ngIf="appConfig.archiveWorkflowEnabled">
<button mat-button (click)="onArchive()" class="button" color="primary">
<mat-icon> archive </mat-icon>
Archive
</button>
<button
mat-button
(click)="onRetrieve()"
class="button"
color="primary"
>
<mat-icon> cloud_download </mat-icon>
Retrieve
</button>
</ng-container>
<configurable-actions *ngIf="appConfig.batchActionsEnabled"
[actionsConfig]="appConfig.batchActions" [actionItems]="actionItems"
[buttonsStyle]="actionButtonsStyle"
(actionFinished)="onActionFinished($event)">
</configurable-actions>
</div>

<mat-table
Expand Down
3 changes: 0 additions & 3 deletions src/app/datasets/batch-view/batch-view.component.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,11 +7,9 @@ import { NO_ERRORS_SCHEMA } from "@angular/core";
import { ActivatedRoute, Router } from "@angular/router";
import {
MockActivatedRoute,
MockArchivingService,
MockDatasetApi,
mockDataset as dataset,
} from "shared/MockStubs";
import { ArchivingService } from "../archiving.service";
import { MatIconModule } from "@angular/material/icon";
import { MatButtonModule } from "@angular/material/button";

Expand Down Expand Up @@ -160,7 +158,6 @@ describe("BatchViewComponent", () => {
TestBed.overrideComponent(BatchViewComponent, {
set: {
providers: [
{ provide: ArchivingService, useClass: MockArchivingService },
{ provide: Router, useValue: router },
{ provide: DatasetsService, useClass: MockDatasetApi },
{ provide: AppConfigService, useValue: { getConfig } },
Expand Down
Loading
Loading