-
Notifications
You must be signed in to change notification settings - Fork 39
refactor(Dataset): change endpoints from V3 to V4 #2380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
abdimo101
wants to merge
29
commits into
master
Choose a base branch
from
change-dataset-endpoints-to-v4
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 24 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
1e74696
wip: for now findbyId, findAll and count has been changed to v4
abdimo101 6c4ce27
wip: creating dataset has been changed to v4
abdimo101 16d26e5
calling public endpoints for unauthenticated users
abdimo101 509434a
eslint fix
abdimo101 c01c30d
fixed tests
abdimo101 234bb7b
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 d89d231
wip: fixed cypress tests, updated cypress commands, replaced old Dtos…
abdimo101 4ab6691
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 29dc498
eslint fix
abdimo101 940ffaf
wip: tests fix
abdimo101 021f93a
wip: e2e test fix
abdimo101 bd7687a
Merge branch 'change-dataset-endpoints-to-v4' of github.com:SciCatPro…
abdimo101 d0c1048
replaced fullfacet and findbyidandupdate v3 to v4, fixed some test er…
abdimo101 97e0bbc
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 113e082
wip: tests fix
abdimo101 ac614ee
wip: e2e tests fix
abdimo101 c62b5be
Merge branch 'change-dataset-endpoints-to-v4' of github.com:SciCatPro…
abdimo101 4dd1d38
temporarily skipping metadata tests since datasets v4 controller does…
abdimo101 62fcc0d
fixed a bug that would not accept decimals inside range values & adde…
abdimo101 b35065c
implemented scientific metadata query for findAllV4
abdimo101 e28660e
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 b058964
removed debug logs
abdimo101 a679cee
Merge branch 'change-dataset-endpoints-to-v4' of github.com:SciCatPro…
abdimo101 26d55d2
fixed post-mergeconflict syntax error in e2e file
abdimo101 576a383
copilot review changes
abdimo101 10b810c
unit tests fix
abdimo101 e7b03c5
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 1c67624
small type fix
abdimo101 4a9ed95
Merge branch 'master' into change-dataset-endpoints-to-v4
abdimo101 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.