feat(table): restyle paginator with compact design and improved layout#2434
Open
nitrosx wants to merge 3 commits into
Open
feat(table): restyle paginator with compact design and improved layout#2434nitrosx wants to merge 3 commits into
nitrosx wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The new global
mat-paginatorand::ng-deep mat-paginator.mat-mdc-paginatorrules will apply to all paginators in the app, not just this table; consider scoping them under.datasets-paginatoror a wrapper to avoid unintended styling elsewhere. - The paginator reordering block assigns
order: 1to multiple elements and then 2/3 to others; double-check whether this ordering achieves the intended sequence or if more explicit, uniqueordervalues would make the layout more predictable. - There are several long commented DOM selector paths and multiple
!importantoverrides in the paginator styles; trimming the comments and refactoring selectors to reduce reliance on::ng-deep/!importantwould make these styles easier to maintain and less brittle against Material DOM changes.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new global `mat-paginator` and `::ng-deep mat-paginator.mat-mdc-paginator` rules will apply to all paginators in the app, not just this table; consider scoping them under `.datasets-paginator` or a wrapper to avoid unintended styling elsewhere.
- The paginator reordering block assigns `order: 1` to multiple elements and then 2/3 to others; double-check whether this ordering achieves the intended sequence or if more explicit, unique `order` values would make the layout more predictable.
- There are several long commented DOM selector paths and multiple `!important` overrides in the paginator styles; trimming the comments and refactoring selectors to reduce reliance on `::ng-deep`/`!important` would make these styles easier to maintain and less brittle against Material DOM changes.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Member
Author
Junjiequan
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
This PR introduces a visual redesign of the paginator component in the dynamic material table to improve user experience and visual consistency.
Motivation
Working with the dynamic material table, we wanted to have a consistent look, reduce the space used and clearly group the controls.
Changes:
Please provide a list of the changes implemented by this PR
Visual Styling:
Element Layout:
Form Field Fixes:
CSS Classes:
datasets-paginatorclass to both header and footer paginatorsdatasets-header-paginatoranddatasets-footer-paginatorfor specific targetingFiles Changed:
src/app/shared/modules/dynamic-material-table/table/dynamic-mat-table.component.html- Added CSS classes to paginator elementssrc/app/shared/modules/dynamic-material-table/table/dynamic-mat-table.component.scss- Complete restyling of paginator appearance and layoutTests included
Documentation
Not applicable
Backend version
AI contribution
In producing this PR, Mistral AI mistral-medium-3.5 has been used through VIBE CLI application and VSCode Extension
Summary by Sourcery
Restyle the dynamic material table paginators with a more compact, theme-aligned layout and updated control ordering.
New Features:
Enhancements: