ci: extract environment-dependent unit tests out of browser E2E matrix jobs

[MohabMohie]

Summary

• e2eTests.yml's Ubuntu_Firefox_Grid/Ubuntu_Chrome_Grid/Ubuntu_MicrosoftEdge_Grid jobs run -Dtest=${GLOBAL_TESTING_SCOPE}, and GLOBAL_TESTING_SCOPE was an unfiltered "everything except a short blocklist" selector — so every Mockito-mocked, environment-independent unit test in shaft-engine rode along inside those live-grid JVMs under -DsetParallel=METHODS, three times over (once per browser). This is the structural root cause S2 (E2E Tests grid suites: fix deterministic cross-browser failing unit-test cluster (env-dependent tests inside browser matrix jobs) #3928, PR Fix grid-CI test-isolation and portability bugs (S2) #3936) band-aided with @Test(singleThreaded = true) rather than fixed.
• Adds 35 individually-verified com.shaft.**.internal unit-test classes (see list below) plus the whole testPackage.unitTests package to GLOBAL_TESTING_SCOPE's exclusion list.
• Widens pr-gate.yml's existing unit-tests job (shaft-engine leg) to run those same 35 classes, so they keep executing — now in their dedicated non-matrix, path-conditioned home instead of a nightly browser-matrix job. testPackage.unitTests already ran there.

Evidence

Each of the 35 moved classes was checked for real driver/grid/network dependency before moving:

• Grepped for new (Chrome|Firefox|Remote|Edge|Safari)WebDriver(, localhost:4444, docker, BrowserStack. outside comments — the only hits are inside Mockito.mockConstruction(...) blocks or string-only property values asserted for branch coverage (e.g. DriverFactoryHelperCoverageUnitTest.closeDriverShouldHandleDockerizedExecutionBranch sets executionAddress("dockerized") as a literal string, never touches real Docker).
• RemoteGridPreflightUnitTest explicitly disables remotePreflightEnabled in @AfterMethod cleanup.
• ImageProcessingActionsScreenshotBaselineUnitTest uses VisualProcessingProviderRegistry.setProviderForTesting(mock(...)), never the real shaft-visual runtime.
• AssertionEvidenceReporterTest / FailureTraceReporterTest (flagged as environment-coupling risks by the S2/E2E Tests grid suites: fix deterministic cross-browser failing unit-test cluster (env-dependent tests inside browser matrix jobs) #3928 fix) use a fake in-process WebDriver implementation (RecordingJavascriptExecutorDriver) and Mockito — no real session.
• All 35 class names were confirmed unique across shaft-engine/src/test/java (no ambiguous -Dtest=SimpleName matches in pr-gate.yml).

Classes moved (e2eTests.yml grid jobs → pr-gate.yml unit-tests job)

DriverFactoryHelperAugmentationUnitTest, DriverFactoryHelperCoverageUnitTest, DriverFactoryHelperStorageStateUnitTest, OptionsManagerCoverageUnitTest, RemoteGridPreflightUnitTest, ActionsCoverageUnitTest, ActionsExceptionDetailsUnitTest, ElementInformationCoverageUnitTest, ElementsHelperCoverageUnitTest, AriaSnapshotHelperUnitTest, MobileAccessibilityTreeConverterUnitTest, AnimatedGifManagerCoverageUnitTest, ImageProcessingActionsReportingUnitTest, ImageProcessingActionsScreenshotBaselineUnitTest, ScreenshotHelperCoverageUnitTest, ScreenshotManagerCoverageUnitTest, LocatorHealthReporterUnitTest, RecordManagerCoverageUnitTest, PlaywrightSessionFactoryStorageStateUnitTest, ShardPartitionerUnitTest, UpdateCheckerUnitTest, LightHouseGenerateReportCoverageUnitTest, PropertiesHelperDownloadRetryUnitTest, PropertyFileManagerInternalUnitTest, AllureManagerCoverageUnitTest, BrowserPerformanceExecutionReportUnitTest, FlakeProfilerUnitTest, ProgressBarLoggerCoverageUnitTest, ValidationsHelperCoverageUnitTest, ValidationsHelperNewPatternCoverageUnitTest, VisualValidationsBuilderUnitTest, WebDriverElementValidationsBuilderAriaSnapshotUnitTest, WebDriverElementValidationsBuilderCoverageUnitTest, AssertionEvidenceReporterTest, FailureTraceReporterTest

plus the whole testPackage.unitTests package (already ran in pr-gate.yml; now also excluded from the grid jobs to stop the redundant/racy triple-execution).

Out of scope (left in place, not touched)

• com.shaft.**.internal classes not suffixed UnitTest (e.g. HealingActionsIntegrationTest, BrowserStorageStateManagerTest, HttpContractBrowserReplayTest) — not individually verified as environment-independent in this pass; left running in the grid jobs.
• com.shaft.**.internal.*UnitTest classes whose names already match an existing GLOBAL_TESTING_SCOPE exclusion (Api/Json/etc., e.g. OpenApiCoverageReporterUnitTest, GoogleTinkApiCoverageUnitTest) — already homed in Ubuntu_APIs, untouched.
• *UnitTest classes outside internal/testPackage.unitTests packages (e.g. AsyncElementActionsCoverageUnitTest, PlaywrightElementActionsUnitTest, AllureListenerCoverageUnitTest) — same racing symptom, but out of this issue's explicitly-scoped pattern; worth a follow-up if the racing recurs.

notify_e2e_tests_failure (PR #3951, S5)

Untouched — no job was renamed or removed, only the GLOBAL_TESTING_SCOPE env var value and pr-gate.yml's existing -Dtest= string changed. Its needs: list still names every real job correctly (verified via yaml.safe_load).

Test plan

• mvn -pl shaft-engine -am -e test-compile — BUILD SUCCESS
• python3 -c "import yaml; yaml.safe_load(...)" on both edited workflow files — parses cleanly, job lists unchanged
• Verified all 35 moved class names are unique within shaft-engine/src/test/java (no ambiguous match risk in pr-gate.yml's -Dtest=)
• Full mvn test grid run not executed locally per repo policy (never run unscoped forked Maven/TestNG runs) — relies on CI (pr-gate.yml unit-tests leg + next e2eTests.yml nightly run) for live confirmation

Closes #3935

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

_{NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.}