fix create tool in the AI chat#6673
Open
EthanHealy01 wants to merge 12 commits into
Open
Conversation
EthanHealy01
requested review from
ConnorYoh,
Frooodle,
Ludy87,
jbrunton96 and
reecebrowne
as code owners
dosubot
Bot
added
size:S
dosubot
Bot
added
size:XXL
stirlingbot
Bot
added
Java
dosubot
Bot
added
size:S
ConnorYoh
reviewed
Jun 16, 2026
jbrunton96
reviewed
Jun 17, 2026
…licy/engine/PolicyExecutor.java remove verbose comments Co-authored-by: James Brunton <jbrunton96@gmail.com>
reecebrowne
previously approved these changes
Jun 17, 2026
# Conflicts: # frontend/editor/src/proprietary/components/chat/ChatContext.tsx # frontend/editor/src/prototypes/components/chat/ChatContext.tsx
dosubot
Bot
added
size:XS
stirlingbot
Bot
removed
Front End
Contributor
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://54.175.155.236:6673 🔐 Secure HTTPS URL: https://6673.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
AI PDF creation ("create a PDF for me") has been broken since the Policies backend (#6527) introduced PolicyExecutor as the tool execution pipeline. PolicyExecutor runs normal single-input tools with a per-file loop, but generator tools like
create-pdf-from-html-agenttake no input file and build their output purely from parameters. With zero input files the loop ran zero times, so the endpoint was never called and the step silently produced nothing. The chat reported success ("Created Purchase Order") while no document ever appeared.This adds an
else if (inputFiles.isEmpty())branch so a generator tool is called once with an empty file list, matching what the multi-input branch already does for an empty input. Two files changed: the one-line-ish fix inPolicyExecutor, and a regression test covering the no-input case.