refactor(shared): make @shared the single home for brand logo assets#6714
refactor(shared): make @shared the single home for brand logo assets#6714reecebrowne wants to merge 1 commit into
Conversation
reecebrowne
requested review from
ConnorYoh,
EthanHealy01,
Frooodle and
jbrunton96
as code owners
dosubot
Bot
added
size:L
stirlingbot
Bot
added
Front End
Frontend Check FailedThere are issues with your frontend code that will need to be fixed before they can be merged in. Run |
Move the editor's classic-logo + modern-logo sets (22 files: marks, wordmarks,
favicons, login headers, PNGs) out of editor/public into shared/assets/brand, so
all brand assets live in the shared design system. The editor's vite build copies
them back to the served /{classic,modern}-logo paths via vite-plugin-static-copy,
so its URL-based variant system, manifests, index.html and useLogoAssets are
unchanged. Adds a Storybook "Brand/Logos" gallery.
Verified: editor builds with the assets in dist, the vite dev server serves them
(HTTP 200), typechecks pass on all flavors, and storybook builds with the gallery.
The portal's existing @shared/assets brand imports are untouched.
reecebrowne
force-pushed
the
feat/shared-branding
branch
from
f9d2982 to
eb58346
Compare
🚀 V2 Auto-Deployment Complete!Your V2 PR with embedded architecture has been deployed! 🔗 Direct Test URL (non-SSL) http://54.175.155.236:6714 🔐 Secure HTTPS URL: https://6714.ssl.stirlingpdf.cloud This deployment will be automatically cleaned up when the PR is closed. 🔄 Auto-deployed for approved V2 contributors. |
📦 Tauri Desktop Builds Ready!The desktop applications have been built and are ready for testing. Download Artifacts:🐧 Linux x64: Download Stirling-PDF-linux-x86_64 (.deb, .rpm, .AppImage) - 830.7 MB Built from commit 2513300 |
1 participant
What
Makes
@sharedthe single home for the Stirling brand logo assets. Moves the editor's two logo sets —classic-logo+modern-logo(22 files: marks, wordmarks, favicons, login headers, PNGs) — out ofeditor/public/intoshared/assets/brand/, and adds a Storybook Brand/Logos gallery.Why this shape (not a plain move)
The editor serves logos by URL from
public/and switchesclassic/modernby a user preference (useLogoAssets,manifest.json/manifest-classic.json,index.htmlfavicon links). Rewiring all that to module imports would be a large, risky change to the variant system.Instead the editor keeps its variant system unchanged and just sources the files from shared:
vite-plugin-static-copycopiesshared/assets/brand/{classic,modern}-logo/*back to the served/{classic,modern}-logopaths (the editor already uses this plugin for pdfium/pdfjs assets). Single source of truth in shared, zero editor code/manifest/markup changes.Verified
dist/{modern,classic}-logo/;manifest.json+ favicon refs resolve./modern-logo/logo512.png,/modern-logo/StirlingPDFLogoNoTextDark.svg,/classic-logo/favicon.icoall return HTTP 200 (the plugin's dev middleware).storybook buildsucceeds with theBrand/Logosgallery bundled.@shared/assetsbrand imports are untouched.Follow-ups (not in this PR)
shared/assets/stirling-mark-*.svgis byte-identical tobrand/modern-logo/StirlingPDFLogoNoTextDark.svg, andstirling-pdf-logo-*is a near-twin of the modern wordmark. Reconciling these (and re-pointing the portal) needs a designer eye on which wordmark is canonical, so it's left out here to avoid changing the portal's rendered logo.editor/src/logo.svgappears unused (no references) — candidate for deletion separately.