Skip to content

fix: hide override not hiding #4008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
leafty wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

fix: hide override not hiding #4008

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions client/src/features/cloudStorage/projectCloudStorage.utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,7 +146,11 @@
return current;
}
const override = CLOUD_STORAGE_OVERRIDE.storage[element.prefix];
if (override && !override.hide) {
console.log({ prefix: element.prefix, override });

Check warning on line 149 in client/src/features/cloudStorage/projectCloudStorage.utils.ts

View workflow job for this annotation

GitHub Actions / test-client 

Unexpected console statement
if (override /* && !override.hide*/) {
if (override.hide) {
return current;
}
current.push({
...element,
name: override.name ?? element.name,
Expand Down Expand Up @@ -241,7 +245,8 @@
if (!targetSchema) return;
const currentSchema = schema.find((s) => s.prefix === targetSchema);
const override = CLOUD_STORAGE_OVERRIDE.storage[targetSchema];
if (currentSchema && override && !override.hide) {
console.log({ targetSchema, override });

Check warning on line 248 in client/src/features/cloudStorage/projectCloudStorage.utils.ts

View workflow job for this annotation

GitHub Actions / test-client 

Unexpected console statement
if (currentSchema && override /*&& !override.hide*/) {
return {
...currentSchema,
name: override.name ?? currentSchema.name,
Expand Down
Loading