feat: add job launcher

[andre-code]

PR to add Job launchers. This PR is part of a larger set of PRs for the full Job launcher feature. This PR only covers adding a launcher, editing its environment, name, desc, and deleting it. The side panel, launcher list, and job submission from a launcher will be covered in other PRs.

Changes

• Add launcher type picker modal
• Add job launcher create flow
• Update API types for job launchers
• Add job command and args fields for launchers (custom + build)
• Show job command and args in view

What is included

• Add a job launcher
• Add, edit a session launcher (backward compatibility)
• Edit job launcher (environment and other properties)
• Delete a launcher

/deploy renku=feat/add-jobs amalthea-sessions=fix/job-status-when-pod-missing renku-data-services=eikek/multiple-jobs-per-launcher extra-values=dataService.imageBuilders.enabled=true,dataService.imageBuilders.strategyName=renku-buildpacks-v3,dataService.imageBuilders.outputImagePrefix=harbor.dev.renku.ch/renku-build/,dataService.imageBuilders.nodeSelector.renku.io/node-purpose=user,dataService.imageBuilders.tolerations[0].effect=NoSchedule,dataService.imageBuilders.tolerations[0].key=renku.io/dedicated,dataService.imageBuilders.tolerations[0].operator=Equal,dataService.imageBuilders.tolerations[0].value=user #no-tests

[RenkuBot]

You can access the deployment of this PR at https://renku-ci-ui-4209.dev.renku.ch

[lorenzo-cavazzi]

Fantastic work! 👏

I added some inline comments, most of them are just minor fixes.

A few additional comments that don't fix easily inline:

• The command and argument descriptions are the same for both "create from code" and "external", but the label is different and it's optional only in one case. Is that intended? Or should we make them consistent?
  

• I noticed the popover showing info on the External job launcher appears incorrectly the first time I hover over the Info icon (at the top of the window). That doesn't happen for the older session launchers. Can you double-check? Here is a video
  

P.S: I see format changes in existing files. You might need to install the latest version of the linting libraries (I would just do a npm ci) and run again npm run format. That should fix some annoying errors

[andre-code]

Thanks @lorenzo-cavazzi for the review. I've added your code suggestions.

• The command and argument descriptions are the same for both "create from code" and "external", but the label is different and it's optional only in one case. Is that intended? Or should we make them consistent?

Is intended, there is a difference between a job command than the command entrypoint, however I will review the texts in other PR with Laura.

• I noticed the popover showing info on the External job launcher appears incorrectly the first time I hover over the Info icon (at the top of the window). That doesn't happen for the older session launchers. Can you double-check?

Yes, fixed!

P.S: I see format changes in existing files. You might need to install the latest version of the linting libraries (I would just do a npm ci) and run again npm run format. That should fix some annoying errors

Thanks for the info!

[lorenzo-cavazzi]

Great!
One last detail. This problem still happens to me.

• I noticed the popover showing info on the External job launcher appears incorrectly the first time I hover over the Info icon (at the top of the window). That doesn't happen for the older session launchers. Can you double-check?

Yes, fixed!

I investigated and it's the component JsonField. The problem is in the child component FormFieldLabel using the following code

<MoreInfo>
  <LazyMarkdown>{info}</LazyMarkdown>
</MoreInfo>

Using the Lazy component here triggers an initial rendering that occupies the wrong space.
The easiest fix is to use Markdown there instead of LazyMarkdown

[lorenzo-cavazzi]

@andre-code this would fix it #4223