fix(scripts): correct model config source path in FP8 low_precision scripts#2094
Open
aoshen02 wants to merge 2 commits into
Open
fix(scripts): correct model config source path in FP8 low_precision scripts#2094aoshen02 wants to merge 2 commits into
aoshen02 wants to merge 2 commits into
Conversation
…cripts
The two FP8 scripts under `scripts/low_precision/` used
`${SCRIPT_DIR}/../scripts/models/` to source the model config, but since
SCRIPT_DIR resolves to `scripts/low_precision/`, the `../scripts/models/`
path expands to `scripts/scripts/models/` which does not exist.
The INT4 scripts in the same directory already use the correct relative
path `../models/`. Align the FP8 scripts to match.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sourcepath in 2 FP8 scripts underscripts/low_precision/${SCRIPT_DIR}/../scripts/models/resolves toscripts/scripts/models/(non-existent) becauseSCRIPT_DIR=scripts/low_precision/${SCRIPT_DIR}/../models/to match the INT4 scripts in the same directoryAffected files
scripts/low_precision/run-qwen3-30b-a3b-fp8.shscripts/low_precision/run-qwen3-4b-fp8.shTest plan
low_precision/scripts now use consistent../models/path🤖 Generated with Claude Code