Fix(rollout): Fail closed on unknown SGLang model names#2112
Open
Baiyu-Su wants to merge 1 commit into
Open
Conversation
Baiyu-Su
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
get_model_url()currently falls back to the default router when a requested model name is missing fromargs.sglang_model_routers. In multi-model SGLang configs, this can silently route requests intended for a reference, reward, teacher, or judge model to the default model router.This PR keeps the legacy fallback only when no router map is registered. If a router map exists and the requested model name is unknown,
get_model_url()now raises a clearValueErrorlisting the available model names.Tests
python -m pytest tests/utils/test_sglang_config.py::TestGetModelUrl -qpre-commit run --files slime/rollout/sglang_rollout.py tests/utils/test_sglang_config.py --show-diff-on-failure --color=always