fix(gpt-oss): update _patch_bridge_expert_cache_to_cpu to match Megatron-Bridge API#2113
Open
aoshen02 wants to merge 1 commit into
Open
fix(gpt-oss): update _patch_bridge_expert_cache_to_cpu to match Megatron-Bridge API#2113aoshen02 wants to merge 1 commit into
aoshen02 wants to merge 1 commit into
Conversation
…ron-Bridge API
radixark/Megatron-Bridge@bridge added a fourth parameter `hf_state_dict` to
`ModelBridge.maybe_modify_converted_hf_weight`. The monkey-patch in
`_patch_bridge_expert_cache_to_cpu` still used the old 3-arg signature, causing
a TypeError when running GPT-OSS weight sync:
TypeError: _patch_bridge_expert_cache_to_cpu.<locals>._patched()
takes 3 positional arguments but 4 were given
Fix: accept and forward the optional `hf_state_dict` argument.
Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
radixark/Megatron-Bridge@bridgeadded a fourth parameterhf_state_dicttoModelBridge.maybe_modify_converted_hf_weight. The monkey-patch in_patch_bridge_expert_cache_to_cpustill uses the old 3-arg signature, causing a crash during GPT-OSS colocated weight sync:The fix accepts and forwards the new optional
hf_state_dictargument.Root cause
Megatron-BridgeupdatedModelBridge.maybe_modify_converted_hf_weightto:The patch only handled 3 args.
Fix
🤖 Generated with Claude Code