Skip to content

fix(test): sync hooks-e2e expected counts after PR #28#29

Merged
jeff-r2026 merged 1 commit into
mainfrom
hotfix/fix-hooks-e2e-count
Jun 15, 2026
Merged

fix(test): sync hooks-e2e expected counts after PR #28#29
jeff-r2026 merged 1 commit into
mainfrom
hotfix/fix-hooks-e2e-count

Conversation

@jeff-r2026

@jeff-r2026 jeff-r2026 commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

背景

PR #28 (Phase 0+Phase 1+P4.4) 在 src/hooks.ts 中新增了 2 个 hook 注册:

  • SessionStart (MR hint — 会话启动时提醒 AI 哪些 merged MR 还没导入)
  • PostToolUse (TodoWrite hint — 提醒调用 teamai-recall subagent)

PR #28 同步更新了 hooks.test.tsusage-tracking.test.tsdoctor.test.ts,但漏改了 hooks-e2e.test.ts,导致 main 分支 CI 中 E2E (GitHub provider, full surface) job 失败:run 27407172848

src/__tests__/hooks-e2e.test.ts:50
  expect(hooks.SessionStart).toHaveLength(2);
  AssertionError: expected ... to have a length of 2 but got 3

修复

仅改测试期望值,业务逻辑不动:

事件 老期望 新期望
SessionStart 2 3
Stop 3 3
PostToolUse 6 7
UserPromptSubmit 2 2
Total 13 15

注:CI 报告里只看到 SessionStart 失败,是因为 vitest expect 在第一次断言失败时抛出,同 it 内后续的 PostToolUse 断言不再执行——属于隐藏的次生失败,本 PR 一并修掉。

测试标题中的 "13 hooks" 也同步改为 "15 hooks"。

本地验证

  • npx vitest run --config vitest.e2e.config.ts src/__tests__/hooks-e2e.test.ts14 passed (14)
  • npx vitest run1356 passed | 4 skipped | 0 failed (1360)
  • npx tsc --noEmit → clean

Test plan

  • CI E2E (GitHub provider, full surface) 在该 PR 上转绿
  • CI 其它 job (Lint & Test, Build) 保持绿

…+ TodoWrite-hint hooks

PR #28 added:
- 1 SessionStart hook (MR hint)
- 1 PostToolUse hook (TodoWrite hint to call teamai-recall subagent)

hooks.test.ts and other unit tests were updated in PR #28, but
hooks-e2e.test.ts was missed, breaking CI on tencent/main.

Update expected counts:
- SessionStart: 2 -> 3
- PostToolUse: 6 -> 7
- title: "13 hooks" -> "15 hooks"

Verified locally:
- vitest e2e: hooks-e2e.test.ts 14/14 pass
- vitest run: 1356 pass / 4 skip / 0 fail
- tsc --noEmit: clean
@jeff-r2026 jeff-r2026 merged commit e85e493 into main Jun 15, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant