Skip to content

feat(ui): redesign commit selector dropdown#2883

Open
daryllimyt wants to merge 1 commit into
codex/simpler-git-syncfrom
feat/commit-selector-redesign
Open

feat(ui): redesign commit selector dropdown#2883
daryllimyt wants to merge 1 commit into
codex/simpler-git-syncfrom
feat/commit-selector-redesign

Conversation

@daryllimyt

@daryllimyt daryllimyt commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Summary

Redesigns the commit selector dropdown (CommitSelector) so the current/HEAD
commit no longer crowds the row.

The previous design rendered a large filled Current • HEAD badge that
wrapped to two lines, collided with the timestamp, and knocked rows out of
alignment.

Changes

  • Replace the oversized combined badge with a left primary accent bar plus a
    soft Current pill; HEAD stays a neutral chip.
  • Add author avatars (initials for people, a bot glyph for [bot]
    accounts) to distinguish human vs automated commits at a glance.
  • Selected row uses a subtle bg-primary/5 tint instead of the heavy grey fill.
  • Tags keep a consistent slot; the relative timestamp is right-aligned with the
    absolute date on hover (title).

Stays flat, neutral, and uses the primary color sparingly per
frontend/CLAUDE.md design rules. Trigger button behavior is unchanged.

Verification

  • pnpm -C frontend exec biome check — clean
  • pnpm -C frontend run typecheck — clean
  • pre-commit hooks (biome + frontend type check) passed

Notes

Scoped to frontend/src/components/registry/commit-selector.tsx. The HTML
design spread used to compare options was kept local and is not part of this PR.


Summary by cubic

Redesigned the commit selector dropdown to reduce clutter and make Current/HEAD status and authors easier to scan. Adds avatars, a clearer selected state, and a tighter row layout without changing behavior.

  • New Features
    • Replaced the combined "Current • HEAD" badge with a left primary accent bar on the selected row and a soft Current pill; HEAD remains a neutral chip.
    • Added author avatars (initials for people, bot icon for [bot] accounts).
    • Cleaner row layout: subtle bg-primary/5 selection tint, line-clamped message, and author • date line.
    • Right-aligned relative timestamp with absolute date on hover; tags use outline chips in a fixed slot.

Written for commit 494800e. Summary will update on new commits.

Review in cubic

@daryllimyt daryllimyt added the ui Improvements or additions to UI/UX label Jun 19, 2026
@zeropath-ai

zeropath-ai Bot commented Jun 19, 2026

Copy link
Copy Markdown

No security or compliance issues detected. Reviewed everything up to 494800e.

Security Overview
Detected Code Changes
Change Type Relevant files
Enhancement ► frontend/src/components/registry/commit-selector.tsx
    Add Avatar and Bot icon to display commit author information
    Implement logic to determine if an author is a bot
    Implement logic to derive author initials for avatar fallback
    Update commit item display to include author avatar and bot indicator

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Confidence score: 5/5

  • Automated review surfaced no issues in the provided summaries.
  • No files require special attention.

Re-trigger cubic

@daryllimyt daryllimyt changed the base branch from main to graphite-base/2883 June 19, 2026 16:59
@daryllimyt daryllimyt force-pushed the graphite-base/2883 branch from 2260e10 to 76730f1 Compare June 19, 2026 16:59
@daryllimyt daryllimyt force-pushed the feat/commit-selector-redesign branch from 8fe0240 to 2c61531 Compare June 19, 2026 16:59
@daryllimyt daryllimyt changed the base branch from graphite-base/2883 to codex/simpler-git-sync June 19, 2026 16:59

daryllimyt commented Jun 19, 2026

Copy link
Copy Markdown
Contributor Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@daryllimyt daryllimyt force-pushed the feat/commit-selector-redesign branch from 2c61531 to c91053d Compare June 19, 2026 18:42
@daryllimyt daryllimyt force-pushed the codex/simpler-git-sync branch from df83851 to 92dfbb2 Compare June 19, 2026 19:22
@daryllimyt daryllimyt force-pushed the feat/commit-selector-redesign branch from c91053d to 494800e Compare June 19, 2026 19:22
@blacksmith-sh

blacksmith-sh Bot commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

Found 8 test failures on Blacksmith runners:

Failures

Test View Logs
tests/workspace-sync-settings.test.tsx/
allows manual git URLs when app repositories are available
View Logs
tests/workspace-sync-settings.test.tsx/
disables the repository selector while repositories are loading
View Logs
tests/workspace-sync-settings.test.tsx/
falls back to manual entry when repositories cannot load
View Logs
tests/workspace-sync-settings.test.tsx/
keeps cached app repositories when a repository refetch errors
View Logs
tests/workspace-sync-settings.test.tsx/
keeps explicit select mode for an existing custom git URL
View Logs
tests/workspace-sync-settings.test.tsx/
opens in manual mode for an existing custom git URL
View Logs
tests/workspace-sync-settings.test.tsx/
preserves a selected app repository's non-main default branch
View Logs
tests/workspace-sync-settings.test.tsx/
selects an app repository when repository options are available
View Logs

Fix in Cursor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui Improvements or additions to UI/UX

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant