add PI group expiration#744
Open
simonLeary42 wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for expiring PI groups based on a stored expiration timestamp by introducing a new SQL table, SQL accessors, and a worker that disables groups whose expiration date has passed, along with a functional test validating the behavior.
Changes:
- Add
pi_group_expiration_datestable (dev bootstrap) and document its creation in the changelog. - Add
UnitySQLAPIs to set/get/list PI group expiration dates. - Add
group-expiry.phpworker plus a functional test to disable expired groups.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| workers/group-expiry.php | New CLI worker to disable PI groups whose expiration date is in the past. |
| tools/docker-dev/sql/bootstrap.sql | Adds pi_group_expiration_dates table to local/dev bootstrap schema. |
| resources/lib/UnitySQL.php | Adds CRUD/list methods for PI group expiration dates. |
| test/functional/WorkerGroupExpiryTest.php | New functional test covering worker behavior and cleanup. |
| test/functional/WorkerUnityCourseTest.php | Removes LDAP-connection reset workaround after running worker subprocess. |
| resources/lib/UnityGroup.php | Sorts group member objects returned by getGroupMembers(). |
| CHANGELOG.md | Notes new required SQL table for the feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
simonLeary42
commented
Jun 11, 2026
Comment on lines
-33
to
-34
| // our LDAP conn doesn't know about changes from subprocess | ||
| unset($GLOBALS["ldapconn"]); |
Member
Author
There was a problem hiding this comment.
This is no longer necessary since executeWorker was updated to pullObject on all LDAP entries in #598
simonLeary42
force-pushed
the
group-expiration
branch
from
ff95791 to
1086a9f
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
simonLeary42
force-pushed
the
group-expiration
branch
from
1086a9f to
c6b33bf
Compare
Member
Author
|
TODO |
Member
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This can be useful for course groups and "trial" groups.