Pr/193#195
Conversation
… tidying up/more documentation
|
I have created a DockerHub organisation, post your docker ID or email if you wanna be added to the org. |
|
My docker id is: psgeorge |
ps-george
left a comment
There was a problem hiding this comment.
Very nice! Makes my hacking session look legitimate ;)
Does this work for you as the dev environment you needed to set up?
I approve for merging into my PR, though not sure the whole PR is ready to be approved.
Think we need to make similar/equivalent changes to the docker image which takes the input file and runs FMark -> It works on my machine but e.g. needing a bash command feels a bit messy. But docker does have issues when dealing with needing to manipulate files because we need to share the volumes, so in a way the current solution is "not bad"..
Haven't fully tested it, but it looks pretty functional. |
improvement on #193
The main issue of #193 is the /home/dockeruser is not writable by
dockeruserand npm complains about not being able to mkdir .cache