fix: escape multiline classloader names in view#3208
Merged
hengyunabc merged 3 commits intoJun 11, 2026
Conversation
There was a problem hiding this comment.
Pull request overview
This PR hardens Arthas’ classloader rendering so classloader names containing control characters (CR/LF/TAB) don’t break table/tree output, and adds regression coverage for the main render paths.
Changes:
- Introduce
ClassUtils.formatClassLoaderTextto normalize CR/LF into a literal\nand TAB into spaces. - Apply normalization to classloader display in
ClassLoaderView(table/tree + section headers) andTypeRenderUtils.drawClassLoader(class detail views). - Add
ClassLoaderViewTestcoverage for multiple render entry points.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| core/src/test/java/com/taobao/arthas/core/command/view/ClassLoaderViewTest.java | Adds regression tests asserting escaped rendering for table/tree/class-detail and headers. |
| core/src/main/java/com/taobao/arthas/core/util/TypeRenderUtils.java | Normalizes classloader strings before building the classloader tree element. |
| core/src/main/java/com/taobao/arthas/core/util/ClassUtils.java | Adds formatClassLoaderText helper for CR/LF/TAB normalization. |
| core/src/main/java/com/taobao/arthas/core/command/view/ClassLoaderView.java | Applies normalization to classloader names/parents in table/tree and related headers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan