Skip to content

fix: limit Windows all-in-one DLL exports#611

Open
feihongxu0824 wants to merge 21 commits into
alibaba:mainfrom
feihongxu0824:fix/windows-explicit-exports
Open

fix: limit Windows all-in-one DLL exports#611
feihongxu0824 wants to merge 21 commits into
alibaba:mainfrom
feihongxu0824:fix/windows-explicit-exports

Conversation

@feihongxu0824

@feihongxu0824 feihongxu0824 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Replace Windows automatic export-all behavior with explicit component-scoped C++ exports.
  • Build normal and export-decorated object variants so static and plugin targets do not inherit dllexport.
  • Add a public shared-library API smoke test and complete the Windows ABI definitions required by exported APIs.

Export scope

  • zvec_ailego: Ailego API
  • zvec_core: Core, Ailego, and Turbo APIs
  • zvec: DB and Ailego APIs; Core and Turbo remain bundled implementation details

Validation

@feihongxu0824
Limit zvec C++ shared exports
9ea48bb
@feihongxu0824
Keep DiskAnnIndex symbols in core shared builds
086c3e7
@feihongxu0824
Scope MSVC all-in-one exports to cloned objects
a746c4c
@feihongxu0824
Revert "Scope MSVC all-in-one exports to cloned objects"
894fcca 
This reverts commit a746c4c.
@feihongxu0824
Limit MSVC explicit exports to zvec all-in-one
33cc12d
@feihongxu0824
Keep MSVC fts_bench on static zvec
2168115
@feihongxu0824
Export core shared ABI helpers
c142bb2
@feihongxu0824
Export bundled public ABI on MSVC
6b88020
@feihongxu0824
Inline Float16 scalar conversions
bbcfe4d
@feihongxu0824
Merge main into windows explicit exports
5bafcc5
@feihongxu0824
Trim unnecessary PR diff
f54a20e
@feihongxu0824
Keep Float16 header-only
3a0dda9
@feihongxu0824
Drop example shared import defines
38476e8
@feihongxu0824
Keep MSVC fts_bench on static zvec
d150b4e
@feihongxu0824
Apply explicit exports to all C++ shared libs
edd1833
@feihongxu0824
Keep DiskAnnIndex linkable when unsupported
497a0ca
@feihongxu0824
Limit explicit exports to zvec shared
d8c09d6
@feihongxu0824
Build Windows DLLs from scoped export objects
2b6e417
@feihongxu0824
Propagate dependencies to object libraries
cd1576f
@feihongxu0824
feihongxu0824 marked this pull request as ready for review July 21, 2026 11:07
@feihongxu0824

feihongxu0824 commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator Author

verified with feihongxu0824#7

richyreachy
richyreachy reviewed Jul 23, 2026
View reviewed changes
Comment thread src/CMakeLists.txt
richyreachy
richyreachy reviewed Jul 23, 2026
View reviewed changes
Comment thread src/core/CMakeLists.txt
richyreachy
richyreachy reviewed Jul 23, 2026
View reviewed changes
Comment thread src/include/zvec/core/interface/index_param.h Outdated
richyreachy
richyreachy reviewed Jul 23, 2026
View reviewed changes
Comment thread src/include/zvec/core/interface/index_param.h Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@richyreachy richyreachy richyreachy left review comments
@chinaux chinaux Awaiting requested review from chinaux chinaux is a code owner
@Cuiyus Cuiyus Awaiting requested review from Cuiyus Cuiyus is a code owner
@JalinWang JalinWang Awaiting requested review from JalinWang JalinWang is a code owner
@iaojnh iaojnh Awaiting requested review from iaojnh iaojnh is a code owner
@zhourrr zhourrr Awaiting requested review from zhourrr zhourrr is a code owner
@egolearner egolearner Awaiting requested review from egolearner egolearner is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@feihongxu0824 feihongxu0824

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@feihongxu0824 @richyreachy