Skip to content

fix(python): validate query field names #612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HosniBelfeki wants to merge 2 commits into
base: main
Choose a base branch
from
+6 −5
Open

fix(python): validate query field names #612

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c088569
fix(python): validate query field names
HosniBelfeki Jul 22, 2026
2c1224a
Merge branch 'main' into fix-python-query-field-name-validation
HosniBelfeki Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions python/tests/test_params.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -408,9 +408,10 @@ def test_init_both_id_and_vector_raises_error(self):
with pytest.raises(ValueError):
Query(field_name="embedding", id="doc123", vector=[0.1])._validate()

def test_init_without_field_name_raises_error(self):
with pytest.raises(ValueError):
Query(field_name=None)._validate()
@pytest.mark.parametrize("field_name", [None, "", " ", 123])
def test_init_without_valid_field_name_raises_error(self, field_name):
with pytest.raises(ValueError, match="Field name must be a non-empty string"):
Query(field_name=field_name)._validate()

def test_has_id_returns_true_when_id_set(self):
vq = Query(field_name="embedding", id="doc123")
Expand Down
4 changes: 2 additions & 2 deletions python/zvec/model/param/query.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,8 +115,8 @@ def has_fts(self) -> bool:
return False

def _validate(self) -> None:
if self.field_name is None:
raise ValueError("Field name cannot be empty")
if not isinstance(self.field_name, str) or not self.field_name.strip():
raise ValueError("Field name must be a non-empty string")
if self.has_id() and self.has_vector():
raise ValueError("Cannot provide both id and vector")
if self.has_fts() and (self.has_vector() or self.has_id()):
Expand Down
Loading