Make test fixtures clean up the bundle and team rows they create#69093
Merged
potiuk merged 1 commit intoJun 30, 2026
Merged
Conversation
anishgirianish
force-pushed
the
fix-test-fixture-cleanup-bundles-teams
branch
6 times, most recently
from
154d55c to
fadb51b
Compare
Contributor
Author
|
cc: @ferruzzi |
|
Nice clean implementation. One minor thought: the early return could be moved up to reduce nesting. But overall this looks solid. |
ferruzzi
reviewed
Jun 29, 2026
ferruzzi
reviewed
Jun 29, 2026
ferruzzi
approved these changes
Jun 29, 2026
ferruzzi
left a comment
ferruzzi
left a comment
Contributor
There was a problem hiding this comment.
Approved, assuming the cleanup steps we no longer need are going to be cleaned up in a follow-up?
Contributor
|
I wonder (as a future idea) if we can somehow use a pre-commit or CI test to enforce using this self-cleaning fixture to ensure we don't regress. |
anishgirianish
force-pushed
the
fix-test-fixture-cleanup-bundles-teams
branch
3 times, most recently
from
868e056 to
17b038c
Compare
Contributor
Author
|
@ferruzzi Thank you so much for the review! Yep, I will follow up with a pr for the clear_db_* cleanup. And love the idea of the enforcement check, I'll look into it there too. thanks |
anishgirianish
force-pushed
the
fix-test-fixture-cleanup-bundles-teams
branch
2 times, most recently
from
4cffd06 to
94c0261
Compare
Contributor
Author
|
Test failures are not related to this pr changes, Opened diffrent pr fixing it as not related and exisits in main: #69163 |
Lee-W
approved these changes
Jun 30, 2026
anishgirianish
force-pushed
the
fix-test-fixture-cleanup-bundles-teams
branch
from
94c0261 to
4a9a920
Compare
anishgirianish
force-pushed
the
fix-test-fixture-cleanup-bundles-teams
branch
from
4a9a920 to
73ab36a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was generative AI tooling used to co-author this PR?
Make the database test fixtures clean up the bundle and team rows they create, in foreign-key-safe order, so tests stop leaking them. Document the fixtures and isolation pattern.
related: #68374
{pr_number}.significant.rst, in airflow-core/newsfragments. You can add this file in a follow-up commit after the PR is created so you know the PR number.