Fix Dag detail page 500 for Dags without a fileloc #69035#69110
Open
haseebmalik18 wants to merge 1 commit into
Open
Fix Dag detail page 500 for Dags without a fileloc #69035#69110haseebmalik18 wants to merge 1 commit into
haseebmalik18 wants to merge 1 commit into
Conversation
haseebmalik18
requested review from
bbovenzi,
bugraoz93,
choo121600,
dheerajturaga,
ephraimbuddy,
guan404ming,
jason810496,
pierrejeambrun,
potiuk,
rawwar,
ryanahamilton,
shubhamraj-git and
vatsrahul1001
as code owners
boring-cyborg
Bot
added
area:airflow-ctl
area:API
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DagModel.filelocis nullable, butDAGResponsetyped it asfileloc: str. So a Dag that has runs but a nullfileloc(for example one run throughdag.test()or the system-test harness) madeGET /dags/{id}and/dags/{id}/detailsfail validation and return 500, leaving the detail page stuck loading.This makes
filelocnullable so those endpoints return 200 and the page renders the Dag with its runs. The OpenAPI spec, UI client, and airflow-ctl datamodels are regenerated to match, and the UI handles a missing file location.closes: #69035