[DO NOT MERGE] test: Scalpel shadow — junit-jupiter 5.14.4→5.14.3#24273
Closed
gnodet wants to merge 9 commits into
Closed
[DO NOT MERGE] test: Scalpel shadow — junit-jupiter 5.14.4→5.14.3#24273gnodet wants to merge 9 commits into
gnodet wants to merge 9 commits into
Conversation
Add a shadow comparison section to CI PR comments showing what Scalpel's skip-tests mode would have tested, without affecting actual test execution. This validates Scalpel's module detection across many PRs before switching to Scalpel-driven test execution. Changes: - incremental-build.sh: switch from GitHub API diff to local git merge-base, configure Scalpel with skipTestsForDownstreamModules and fetchBaseBranch=false, add writeScalpelComparison() for collapsible PR comment section - pr-build-main.yml / sonar-build.yml: add base branch fetch step for Scalpel's merge-base detection in shallow CI clones - CI-ARCHITECTURE.md: document shadow comparison approach and configuration
The checkout action was accidentally downgraded from v7.0.0 to v6.0.2, and persist-credentials: false was dropped from sonar-build.yml. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ION_LIST Restore fetchDiff() to use the GitHub API (unchanged from main) instead of local git merge-base. The grep-based script has no dependency on local git history — only Scalpel needs it. This eliminates regression risk for the existing incremental build path. Also derive skip_downstream from EXCLUSION_LIST via sed instead of hardcoding a duplicate list that could silently diverge. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
When Scalpel fails (mvn validate error, missing report due to shallow clone depth, or full-build trigger), surface the reason in the PR comment's shadow comparison section instead of silently omitting it. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Scalpel 0.3.5 still includes ~600 uncategorized parent-inherited modules in affectedModules (scalpel#39, regression from apache#30 fix). Filter jq queries to only DIRECT and DOWNSTREAM categories, and compute the summary count from the breakdown rather than the inflated total. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…ules" This reverts commit 7da4738.
Fixes inflated affectedModules count — parent-inherited modules that don't use the changed dependency are no longer included (scalpel#39). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Fixes inflated affectedModules count where parent POM property changes (e.g. kafka-version) were reported as affecting all ~670 modules. Also fixes skipTestsForDownstreamModules not taking effect. See maveniverse/scalpel#39 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Validates Scalpel shadow comparison for a test-scoped managed dependency change. Excludes .mvn/** from Scalpel diff (this PR inherits .mvn/extensions.xml changes). Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
|
🌟 Thank you for your contribution to the Apache Camel project! 🌟 🐫 Apache Camel Committers, please review the following items:
|
Contributor
|
🧪 CI tested the following changed modules:
✅ POM dependency changes: targeted tests included Changed properties: junit-jupiter-version Changed managed dependencies: org.junit:junit-bom Modules affected by dependency changes (42)
🔬 Scalpel shadow comparison (skip-tests mode)Scalpel skip-tests mode would test 13 modules (3 direct + 10 downstream) 29 downstream module(s) would have tests skipped (generated code, meta-modules) Modules Scalpel would test (13)
Modules with tests skipped (29)
All tested modules (44 modules)
|
Contributor
Author
|
Closing — Claude Code on behalf of @gnodet |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scalpel shadow comparison validation — junit-jupiter-version
Temporary PR to validate PR #22524's Scalpel shadow comparison with a test-scoped managed dependency change.
Change:
junit-jupiter-version5.14.4 → 5.14.3 inparent/pom.xmlExpected result:
${junit-jupiter-version}directlyThis PR should be closed without merging once the shadow comparison is validated.
Claude Code on behalf of @gnodet