Add ScalarUDF preserves_lex_ordering FFI support#23069
Open
Amogh-2404 wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
This changes the |
|
Thank you for opening this pull request! Reviewer note: cargo-semver-checks reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). Details |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
FFI_ScalarUDFsilently drops producer overrides of defaulted trait methods #22330.Rationale for this change
FFI_ScalarUDFdid not exposeScalarUDFImpl::preserves_lex_ordering, so a producer override was lost when the UDF crossed the FFI boundary.What changes are included in this PR?
preserves_lex_orderingtoFFI_ScalarUDF.ExprPropertiesthrough the existing FFI representation.Are these changes tested?
cargo fmt --allcargo test -p datafusion-fficargo test -p datafusion-ffi --features integration-testscargo clippy -p datafusion-ffi --all-targets --all-features -- -D warningsAre there any user-facing changes?
No end-user behavior change. This updates the DataFusion FFI ABI.