FINERACT-2649: Migrate Tier 1 loan integration tests to Feign client#6005
Open
DeathGun44 wants to merge 1 commit into
Open
FINERACT-2649: Migrate Tier 1 loan integration tests to Feign client#6005DeathGun44 wants to merge 1 commit into
DeathGun44 wants to merge 1 commit into
Conversation
Member
|
@DeathGun44 pls try rebase |
DeathGun44
force-pushed
the
FINERACT-2649/batch-migrate-loan-tests-to-feign-s1
branch
from
97fc7c9 to
bd1f0eb
Compare
Contributor
Author
|
@Aman-Mittal Done! |
DeathGun44
force-pushed
the
FINERACT-2649/batch-migrate-loan-tests-to-feign-s1
branch
4 times, most recently
from
b3c87d6 to
d1fbbe7
Compare
budaidev
reviewed
Jun 21, 2026
| * Updates a loan product using raw JSON. Use this overload when you need to send explicit null values in the | ||
| * request body, which the typed Feign client cannot express due to the global NON_NULL ObjectMapper configuration. | ||
| */ | ||
| protected void updateLoanProduct(Long productId, String rawJsonBody) { |
Contributor
There was a problem hiding this comment.
I understand this is a workaround, but this change will force to load restassured on every subclass, which is not ideal. Can we separate this
Contributor
Author
There was a problem hiding this comment.
Done! It's now a private method in FixedLengthLoanProductIntegrationTest.
| LoanTestValidators.verifyRepaymentSchedule(loanDetails, installments); | ||
| } | ||
|
|
||
| protected PostLoanProductsRequest create4IProgressive() { |
Contributor
There was a problem hiding this comment.
Can we consolidate this kind of product creation into the LoanProductTemplates? I think this belongs there
Contributor
Author
There was a problem hiding this comment.
Done. Moved create4IProgressive() to LoanProductTemplates as a default method.
|
|
||
| public Long createClient() { | ||
| return createClient(Utils.dateFormatter.format(Utils.getLocalDateOfTenant())); | ||
| return createClient("04 March 2011"); |
DeathGun44
force-pushed
the
FINERACT-2649/batch-migrate-loan-tests-to-feign-s1
branch
from
d1fbbe7 to
74ae125
Compare
Signed-off-by: DeathGun44 <krishnamewara841@gmail.com>
DeathGun44
force-pushed
the
FINERACT-2649/batch-migrate-loan-tests-to-feign-s1
branch
from
74ae125 to
db1f724
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Migrates 5 Tier 1 loan integration tests from
BaseLoanIntegrationTest(REST-assured) toFeignLoanTestBase(Feign client).Migrated tests
LoanPrepayAmountTestLoanProductWithChargeOffBehaviourTestLoanInterestRateFrequencyTestLoanDueCalculationTestFixedLengthLoanProductIntegrationTestInfrastructure additions
retrieveLoanProductandupdateLoanProduct(typed) methods toFeignLoanHelperupdateLoanProduct(Long, String)raw JSON overload inFeignLoanTestBasefor explicit null values (theNON_NULLObjectMapper prevents typed null serialization)requestSpec/responseSpectoFeignLoanTestBasefor raw JSON edge casesLoanProductTemplates(onePeriod30DaysPeriodicAccrual,fourPeriod1MonthWithoutInterest, etc.)LoanRequestBuilders(applyLoanRequest,applyLP2ProgressiveLoanRequest,approveLoanwith expected disbursement date)LoanTestValidators(verifyRepaymentSchedule,verifyTransactions)FeignLoanTestBasewith migrated helpers fromBaseLoanIntegrationTest(product builders, installment/transaction wrappers,create4IProgressive, etc.)Bug fixes
FeignClientHelper.createClient()- use fixed past activation date (04 March 2011) matchingClientHelper.DEFAULT_DATEinstead of real system dateFeignBusinessDateHelper- added overloads accepting an explicitdateFormatparameterFeignLoanTestBase.runAt()/updateBusinessDate()- auto-detect date format (yyyy-MM-ddfor ISO dates,dd MMMM yyyyfor human-readable dates) so migrated tests and existing Feign tests remain compatibleChecklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.