Skip to content

FINERACT-2643: Refactor NewCommandSourceHandler implementation classes to use @RequiredArgsConstructor Lombok#6006

Open
atharva-kamat wants to merge 1 commit into
apache:developfrom
atharva-kamat:refactor/cleanup-unnecessary-commandhandlerannotations
Open

FINERACT-2643: Refactor NewCommandSourceHandler implementation classes to use @RequiredArgsConstructor Lombok#6006
atharva-kamat wants to merge 1 commit into
apache:developfrom
atharva-kamat:refactor/cleanup-unnecessary-commandhandlerannotations

Conversation

@atharva-kamat

Copy link
Copy Markdown

Description

Refactor command handlers to use Lombok @requiredargsconstructor for constructor injection

While the majority of our newer components and services across the codebase correctly leverage Lombok's @requiredargsconstructor to handle clean constructor-based dependency injection, several older command handler classes (such as UpdateReportCommandHandler, {}UpdateJobDetailCommandhandler{}) present in fineract-provider are still using explicit manual constructors combined with redundant @Autowired annotations.

Checklist

Please make sure these boxes are checked before submitting your pull request - thanks!

  • [y] Write the commit message as per our guidelines
  • [y] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
  • [y] Create/update unit or integration tests for verifying the changes made.
  • [y] Follow our coding conventions.
  • [y] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
  • [y] This PR must not be a "code dump". Large changes can be made in a branch, with assistance. Ask for help on the developer mailing list.

Your assigned reviewer(s) will follow our guidelines for code reviews.

@Aman-Mittal

Copy link
Copy Markdown
Member

@atharva-kamat Your PR touches lot of files maybe you can split this into small PRs

@atharva-kamat

Copy link
Copy Markdown
Author

@Aman-Mittal I managed to somewhat figure out issue here.

Context:
I have a windows 11 machine with two github accounts. Both of them do not have gpg keys linked to their github accounts. I had forked and clone the repository on this account. But i committed and pushed it with another git account.

Status:
Now, i have created and configured the gpg key for this account on machine and github.

What should i do next?
As you mentioned. @Aman-Mittal
Since I have only one commit, I will create a new pr. I think it will be better than amend existing commit and force push.

@Aman-Mittal

Copy link
Copy Markdown
Member

@Aman-Mittal I managed to somewhat figure out issue here.

Context:
I have a windows 11 machine with two github accounts. Both of them do not have gpg keys linked to their github accounts. I had forked and clone the repository on this account. But i committed and pushed it with another git account.

Status:
Now, i have created and configured the gpg key for this account on machine and github.

What should i do next?
As you mentioned. @Aman-Mittal
Since I have only one commit, I will create a new pr. I think it will be better than amend existing commit and force push.

You can ammend the commit and also rebase against develop

@atharva-kamat

Copy link
Copy Markdown
Author

Thanks for your guidance. I’ve gone ahead with a new PR for clarity, safety and simplicity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants