You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While the majority of our newer components and services across the codebase correctly leverage Lombok's @requiredargsconstructor to handle clean constructor-based dependency injection, several older command handler classes (such as UpdateReportCommandHandler, {}UpdateJobDetailCommandhandler{}) present in fineract-provider are still using explicit manual constructors combined with redundant @Autowired annotations.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
[y] Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
[y] Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
@Aman-Mittal I managed to somewhat figure out issue here.
Context:
I have a windows 11 machine with two github accounts. Both of them do not have gpg keys linked to their github accounts. I had forked and clone the repository on this account. But i committed and pushed it with another git account.
Status:
Now, i have created and configured the gpg key for this account on machine and github.
What should i do next?
As you mentioned. @Aman-Mittal
Since I have only one commit, I will create a new pr. I think it will be better than amend existing commit and force push.
@Aman-Mittal I managed to somewhat figure out issue here.
Context:
I have a windows 11 machine with two github accounts. Both of them do not have gpg keys linked to their github accounts. I had forked and clone the repository on this account. But i committed and pushed it with another git account.
Status:
Now, i have created and configured the gpg key for this account on machine and github.
What should i do next?
As you mentioned. @Aman-Mittal
Since I have only one commit, I will create a new pr. I think it will be better than amend existing commit and force push.
You can ammend the commit and also rebase against develop
Thanks for your guidance. I’ve gone ahead with a new PR for clarity, safety and simplicity.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor command handlers to use Lombok @requiredargsconstructor for constructor injection
While the majority of our newer components and services across the codebase correctly leverage Lombok's @requiredargsconstructor to handle clean constructor-based dependency injection, several older command handler classes (such as UpdateReportCommandHandler, {}UpdateJobDetailCommandhandler{}) present in fineract-provider are still using explicit manual constructors combined with redundant @Autowired annotations.
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Your assigned reviewer(s) will follow our guidelines for code reviews.