Apply GCD bound transform to sorted numeric rangeIntoBitSet#16285
Open
costin wants to merge 2 commits into
Open
Apply GCD bound transform to sorted numeric rangeIntoBitSet#16285costin wants to merge 2 commits into
costin wants to merge 2 commits into
Conversation
GCD- and delta-encoded multi-value SortedNumericDocValues decode every packed value during range evaluation. This transforms query bounds into the encoded domain and compares raw values directly, matching the recipe used for single-value NumericDocValues.
Contributor
|
Nice! I was also working on this and had a PR ready before I found out that you already did this! 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCD- and delta-encoded multi-value SortedNumericDocValues decode every packed value during range evaluation. This transforms query bounds into the encoded domain and compares raw values directly, matching the recipe used for single-value NumericDocValues.
Uses the same approach as #16160 (the same utility methods are used, will be removed once that PR gets merged)
Benchmark
SortedNumericGcdRangeIntoBitSetBenchmark, 1M docs, JDK 25.0.3.
AMD EPYC 7R32 (c5a.2xlarge) — AVX2, 256-bit
Intel Xeon 8375C (c6i.2xlarge) — AVX-512, 512-bit