Skip to content

NIFI-16064 - Preserve local public port names on version control update#11384

Open
pvillard31 wants to merge 1 commit into
apache:mainfrom
pvillard31:NIFI-16064
Open

NIFI-16064 - Preserve local public port names on version control update#11384
pvillard31 wants to merge 1 commit into
apache:mainfrom
pvillard31:NIFI-16064

Conversation

@pvillard31

Copy link
Copy Markdown
Contributor

Summary

NIFI-16064 - Preserve local public port names on version control update

When a public port (an input/output port that allows remote access) inside a versioned process group is renamed locally (ex: "Copy of " collision when the group is reused), that rename was discarded on the next version update, reverting to the registry-defined name. The cause is that a public port name change is treated as environmental (so it isn't surfaced as a local modification) yet is not excluded from the synchronizer's update logic. This adds a preservePublicPortNames option on FlowSynchronizationOptions, enabled only by StandardProcessGroup.updateFlow (the version-control update path), so the synchronizer keeps the local name; cluster reconnection and startup leave it disabled and still adopt the incoming flow's names. The affected-components calculation is aligned so a preserved name no longer needlessly stops the running port. Covered by new tests in StandardVersionedComponentSynchronizerTest and TestFlowDifferenceFilters.

Tracking

Please complete the following tracking steps prior to pull request creation.

Issue Tracking

Pull Request Tracking

  • Pull Request title starts with Apache NiFi Jira issue number, such as NIFI-00000
  • Pull Request commit message starts with Apache NiFi Jira issue number, as such NIFI-00000
  • Pull request contains commits signed with a registered key indicating Verified status

Pull Request Formatting

  • Pull Request based on current revision of the main branch
  • Pull Request refers to a feature branch with one commit containing changes

Verification

Please indicate the verification steps performed prior to pull request creation.

Build

  • Build completed using ./mvnw clean install -P contrib-check
    • JDK 21
    • JDK 25

Licensing

  • New dependencies are compatible with the Apache License 2.0 according to the License Policy
  • New dependencies are documented in applicable LICENSE and NOTICE files

Documentation

  • Documentation formatting appears as expected in rendered files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant