NIFI-16067 - PutIcebergRecord maps fields by ordinal position instead of column name#11387
Open
maltesander wants to merge 2 commits into
Open
NIFI-16067 - PutIcebergRecord maps fields by ordinal position instead of column name#11387maltesander wants to merge 2 commits into
maltesander wants to merge 2 commits into
Conversation
exceptionfactory
left a comment
Contributor
There was a problem hiding this comment.
Thanks for flagging and addressing this issue @maltesander. The general approach looks good, I will take a closer look at the changes and follow up soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NIFI-16067 - PutIcebergRecord maps fields by ordinal position instead of column name
PutIcebergRecord (added in NIFI-15062) doesn't match columns by name. It writes each record's values into the Iceberg table columns by position, and the position it uses is the one from the incoming record schema, not the table schema. So the mapping is wrong whenever the input field order doesn't line up with the table's column order.
If the record has fewer fields than the table, the missing columns aren't set to NULL either - the values just shift left into whatever table column happens to sit at that position. Sometimes that lands on an incompatible type and you get a ClassCastException, which is the good outcome because at least it fails loudly. When the types happen to line up, the row is written with values in the wrong columns and nothing complains.
This gets worse with schema evolution: as soon as you add a column, the producer and the table no longer agree on the column set, and existing flows start silently writing data into the wrong place.
Tracking
Please complete the following tracking steps prior to pull request creation.
Issue Tracking
Pull Request Tracking
NIFI-00000NIFI-00000VerifiedstatusPull Request Formatting
mainbranchVerification
Please indicate the verification steps performed prior to pull request creation.
Build
./mvnw clean install -P contrib-checkLicensing
LICENSEandNOTICEfilesDocumentation