feat(services/http): support if_modified_since and if_unmodified_since#7636
Open
YuangGao wants to merge 1 commit into
Open
feat(services/http): support if_modified_since and if_unmodified_since#7636YuangGao wants to merge 1 commit into
YuangGao wants to merge 1 commit into
Conversation
dosubot
Bot
added
size:S
YuangGao
force-pushed
the
feat/http-conditional-read
branch
from
570288e to
324ccaa
Compare
Contributor
Author
|
@Xuanwo This is ready for review. The failing checks are unrelated flaky tests. Could you help re-run them? Thanks! |
Inject If-Modified-Since and If-Unmodified-Since in http_get_request and http_head_request, and declare the matching read/stat capabilities. Part of apache#5486.
YuangGao
force-pushed
the
feat/http-conditional-read
branch
from
2aeec52 to
8c083c3
Compare
erickguan
reviewed
Jun 24, 2026
|
|
||
|
|
||
| @pytest.mark.need_capability( | ||
| "read", "read_with_if_modified_since", "read_with_if_unmodified_since" |
Member
There was a problem hiding this comment.
Hmm, what does this change for python binding?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Part of #5486.
Rationale for this change
The http service already wires
if_match/if_none_matchon read and stat. RFC 7232 definesIf-Modified-Since/If-Unmodified-Sinceas the date-based counterparts, and they're standard on every HTTP/1.1 serverWhat changes are included in this PR?
If-Modified-Since/If-Unmodified-Sinceinhttp_get_requestandhttp_head_request.read_with_if_modified_since,read_with_if_unmodified_since,stat_with_if_modified_since,stat_with_if_unmodified_sinceon the http service capability.Are there any user-facing changes?
Yes —
op.reader_with(path).if_modified_since(...)/if_unmodified_since(...)(and the stat equivalents) now work against http backends. No breaking changes.AI Usage Statement
AI-assisted implementation.