HDDS-15664. ozone debug ldb display DeletedBlocksTransactionSummary info#10614
Open
ChenSammi wants to merge 1 commit into
Open
HDDS-15664. ozone debug ldb display DeletedBlocksTransactionSummary info#10614ChenSammi wants to merge 1 commit into
ChenSammi wants to merge 1 commit into
Conversation
priyeshkaratha
approved these changes
Jun 26, 2026
priyeshkaratha
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ChenSammi for the patch. Changes LGTM
Tejaskriya
approved these changes
Jun 26, 2026
adoroszlai
requested changes
Jun 26, 2026
adoroszlai
left a comment
Contributor
There was a problem hiding this comment.
Thanks @ChenSammi for the patch. DBScanner is very generic, but the PR adds tightly coupled parse logic. Can you please explain why this is needed, why STATEFUL_SERVICE_CONFIG is the only column family that needs special care? If the current logic cannot parse it, can it be implemented in a way that helps with any other column families not handled currently?
Comment on lines
+844
to
+847
| } catch (InvalidProtocolBufferException e) { | ||
| LOG.error("Failed to parse {} for key {}", STATEFUL_SERVICE_CONFIG.getName(), SERVICE_NAME, e); | ||
| } catch (IOException e) { | ||
| LOG.error("Failed to parse {} for key {}", STATEFUL_SERVICE_CONFIG.getName(), SERVICE_NAME, e); |
Contributor
There was a problem hiding this comment.
Duplicate catch blocks, please merge them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add support in ldb scan command, to display DeletedBlocksTransactionSummary info.
What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-15664
How was this patch tested?
Manual test