HDDS-15679. [Recon] Fix DN dropdown mismatch with pending deletion API#10615
Open
priyeshkaratha wants to merge 1 commit into
Open
HDDS-15679. [Recon] Fix DN dropdown mismatch with pending deletion API#10615priyeshkaratha wants to merge 1 commit into
priyeshkaratha wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
The DN pending deletion API is fetched with limit=15, returning pending block size data for at most 15 datanodes. However, the node-selector dropdown on the Capacity page was populated from storageDistribution, which returns all datanodes in the cluster. This caused a mismatch: the dropdown could list nodes for which no pending deletion data existed, while the nodes actually covered by the API response might be missing from the dropdown. Selecting such a node would show a pending block size of zero regardless of the actual value.
Corrected two broken regex patterns that did not match the actual rendered text, updated totalReplicatedBlockSize to 3072 (= 3× totalBlocksize, consistent with Ratis RF3), and adjusted the dependent numeric assertions accordingly.
Also fixed the polling issue found during testing the code.
What is the link to the Apache JIRA
HDDS-15679
How was this patch tested?
Tested manually.