Skip to content

HDDS-15605. Fix flaky testContainerExclusionWithClosedContainerException #10621

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
chihsuan wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −1
Open

HDDS-15605. Fix flaky testContainerExclusionWithClosedContainerException #10621

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion ...on-test/src/test/java/org/apache/hadoop/ozone/client/rpc/TestFailureHandlingByClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,7 +394,12 @@ public void testContainerExclusionWithClosedContainerException()

assertThat(keyOutputStream.getExcludeList().getContainerIds())
.contains(ContainerID.valueOf(containerId));
assertThat(keyOutputStream.getExcludeList().getDatanodes()).isEmpty();
// Datanodes are not asserted here. Under the default ALL_COMMITTED watch
// level a slow-but-healthy follower can be recorded in the exclude list, so
// an empty datanode set is not an invariant for this config (the watch
// level is configurable via RatisClientConfig watchType, HDDS-2887).
// Watch-level datanode exclusion is covered by
// testDatanodeExclusionWithMajorityCommit.
assertThat(keyOutputStream.getExcludeList().getPipelineIds()).isEmpty();

// The close will just write to the buffer
Expand Down