[core] Add file format provider SPI#8292
Open
tchivs wants to merge 11 commits into
Open
Conversation
tchivs
changed the title
…rmat-spi # Conflicts: # paimon-core/src/main/java/org/apache/paimon/schema/SchemaValidation.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Follow-up to #8193, which lets
engines create a
CatalogContextwithout loading Hadoop configuration when theyprovide their own
FileIOloader.That removes one Hadoop initialization path, but ORC/Parquet format construction
can still fall back to Hadoop-backed implementations in some scenarios. This PR
adds an experimental
FileFormatProviderSPI so engines can supply ORC/Parquetformat implementations at runtime.
The built-in
FileFormatFactorylookup remains the default fallback. Catalogtable-runtime.*options can inject providers without persisting them to tableschemas.
Runtime table options are only used while constructing and validating tables;
they are not persisted into table schemas, and
table-runtime.pathdoes notoverride the real table path.
A related motivation is supporting engines that provide their own native file
format implementations while reducing Hadoop/Hive dependencies, e.g.
trinodb/trino#15921.
Tests
mvn -pl paimon-common,paimon-core,paimon-format -am -Pfast-build -DfailIfNoTests=false -Dtest=CoreOptionsTest,FileFormatProviderTest,FormatProviderNoHadoopTest testmvn -pl paimon-bundle -am -Pfast-build -DskipTests installmvn -pl paimon-api,paimon-common,paimon-core -am -DskipTests spotless:checkgit diff --check apache/master...HEADmvn -N org.apache.rat:apache-rat-plugin:0.15:checkmvn -pl paimon-core -am -Pfast-build -DfailIfNoTests=false -Dtest=FallbackReadFileStoreTableTest#testSwitchToBranch testmvn -pl paimon-common,paimon-core,paimon-format -am -Pfast-build -DfailIfNoTests=false -Dtest=FileFormatProviderTest,FormatProviderNoHadoopTest,FileSystemCatalogTest#testCreateTableWithRuntimeCatalogOptions,SchemaValidationTest#testDynamicOptionsCanRemoveSchemaOptionsDuringValidation+testSnapshotSequenceOrderingHonorsDynamicWriteOnlyValue,SchemaManagerTest#testCreateTableWithDynamicOptions+testCommitChangesWithDynamicOptions,FileMetaUtilsTest,FallbackReadFileStoreTableTest#testSwitchToBranch,CoreOptionsTest,FileFormatTest test